Repository navigation
test: share an input item types helper across gateway continuation tests - #545
Merged
maralbahari merged 1 commit intoNov 16, 2026
Merged
Conversation
Signed-off-by: Than0316 <tassel0316@gmail.com>
Than0316
requested review from
bbrowning,
franciscojavierarceo,
haoshan98,
jiahuei,
leseb,
maralbahari,
noobHappylife,
qandrew and
tjtanaa
as code owners
November 15, 2026 21:30
maralbahari
approved these changes
Nov 16, 2026
LeaderOnePro
added a commit
to LeaderOnePro/agentic-api
that referenced
this pull request
Nov 16, 2026
Bring in model capability validation (vllm-project#512), unknown conversation id rejection (vllm-project#531), persisted-turn documentation (vllm-project#533), and the shared input-item test helper (vllm-project#545). Signed-off-by: LeaderOnePro <LeaderOnePro@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to @maralbahari's nit on #519: the MCP and web search continuation tests each defined the same closure to list the
typeof every input item in a request body sent upstream. This moves it totests/supportasinput_item_typesand uses it in both tests.Test Plan
cargo test -p agentic-server-core --test mcp_tool_test --test web_search_tool_test --test hosted_tool_search_projection_teston main: 18, 36 and 8 passed.cargo fmt -- --check;cargo clippy --all-targets -- -D warnings(whole workspace, sincetests/supportis compiled into every core test binary).pre-commit runon the changed files.