Skip to content

fix: accept Codex function call output IDs - #557

Closed
franciscojavierarceo wants to merge 1 commit into
mainfrom
codex/fix-codex-tool-output-ids
Closed

franciscojavierarceo wants to merge 1 commit into
mainfrom
codex/fix-codex-tool-output-ids

Conversation

@franciscojavierarceo

Copy link
Copy Markdown
Collaborator

Summary

Codex tool continuations failed with a 400 when function-call outputs included an fco_ item ID. Accept that prefix for function-call outputs alongside existing fc_ IDs, preserving item identity and call_id while retaining validation for other item types.

Test Plan

  • Item-ID regressions, stored/unstored WebSocket continuations, installed-server smoke test, and all pre-commit hooks passed.
  • Workspace run: two unrelated Messages tests failed (504 instead of 502), also reproduced in isolation. Clippy reports unchanged-code issues under Rust 1.99.

Signed-off-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
@maralbahari

Copy link
Copy Markdown
Collaborator

@franciscojavierarceo #553 already solves this issue?! this solution here to gate it with the bool statement is not ideal for book keeping and it is not limited to only function_call it's also for shell_call and custom_call so in #553 I tried to add in the list of InOutItems.id_prefix as a list so the bookkeeping is easy to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants