Repository navigation
feat: add conversation memory service prototype - #565
Draft
franciscojavierarceo wants to merge 2 commits into
Draft
franciscojavierarceo wants to merge 2 commits into
franciscojavierarceo wants to merge 2 commits into
Conversation
Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com>
Signed-off-by: Francisco Javier Arceo <4163062+franciscojavierarceo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in Rust memory-service prototype over the existing file-search ingestion and retrieval service. It stores summaries and bounded searchable transcripts, retrieves owner-filtered temporary model context, and supports forgetting; the demo verifies recall across a SQLite database restart.
Refs #563, which tracks automatic Responses integration. This PR is a library prototype: it adds no automatic recall/summarization hooks, HTTP memory settings, private-store ACLs, default-store provisioning, or background replacement jobs.
Changes by API
Flow
flowchart LR App["Application: resolved owner, completed stored response, summary"] --> Memory["NEW MemoryService"] Memory --> Files["Existing FileSearchService"] Files --> Storage["Existing repository and blob store"] Files --> Recall["NEW bounded MemoryContext"] Recall --> AppNew modules
types/memory.rs: resolved owner, options, and summary/transcript contracts.tool/memory/mod.rs: memory operations composed with the existing file-search service.tool/memory/context.rs: bounded JSON-encoded excerpts and temporary model-message projection.Design, limitations, and supplementary class diagram.
Test Plan
cargo test -p agentic-server-core --lib --test memory_service --test file_search_service --test file_search_tool_test --offline: 1,533 passed, 9 ignored (existing manual/environment-dependent cases, including PostgreSQL).cargo clippy -p agentic-server-core --all-targets --offline -- -D warnings: passed.uvx --offline pre-commit run --all-files, formatting, and diff checks: passed.cargo run -p agentic-server-core --example memory_demo --offline: passed; write → reopen database → recall → owner-isolation check → forget.