Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: select Rust toolchain
# Install the pinned development/GUI toolchain. Headless MSRV is checked below.
run: |
rustup toolchain install 1.98.1 --profile minimal --component clippy,rustfmt
rustup toolchain install 1.100.0 --profile minimal --component clippy,rustfmt

# Caches ~/.cargo and target/ without the workspace's own build
# products, keyed by job, toolchain and Cargo.lock. Third-party action:
Expand Down Expand Up @@ -72,10 +72,11 @@ jobs:
# --all-targets does not include doctests.
run: cargo test --locked --doc

- name: test with the audio feature
- name: build tests with the audio feature
# Otherwise only clippy ever compiles `audio`; libasound2-dev is
# installed above.
run: cargo test --locked --features audio --lib
# installed above. No unit test uses the audio code, so the step
# builds and links the tests rather than run them a second time.
run: cargo test --locked --features audio --lib --no-run

- name: native GUI interactions (headless test window)
run: cargo test --locked --features gui-tests --bin ember gui_native::kit_tests
Expand All @@ -92,7 +93,7 @@ jobs:

- name: headless check on the MSRV (no gui feature)
# `+1.92.0` overrides rust-toolchain.toml, so this is the x86_64
# counterpart of the arm64 job's MSRV check rather than another 1.98.1
# counterpart of the arm64 job's MSRV check rather than another 1.100.0
# build.
run: |
rustup toolchain install 1.92.0 --profile minimal
Expand Down Expand Up @@ -202,7 +203,7 @@ jobs:
steps:
- uses: actions/checkout@v4

# No explicit toolchain install: rust-toolchain.toml pins 1.98.1, which
# No explicit toolchain install: rust-toolchain.toml pins 1.100.0, which
# is what the GUI features need. The Linux jobs install a *different*
# version on purpose (1.92.0 on arm64 to prove the headless MSRV), so
# they cannot be copied here.
Expand All @@ -227,7 +228,7 @@ jobs:
- name: clippy (headless)
# The same 1.98 chunks_exact carve-out as the x86_64 job: it is a new
# style lint, and the measured kernel loop shapes are intentionally
# retained. Omitting it here would fail on 1.98.1.
# retained. Omitting it here would fail on 1.100.0.
run: cargo clippy --locked --no-default-features --all-targets -- -D warnings -A clippy::chunks_exact_to_as_chunks

- name: gui compile check (Metal)
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@ Work after the 1.0.0 candidate. It is not part of the staged 1.0.0 release.
`rc_buffer`, `dbg_macro` and `todo`. Every `#[allow]` now states its
reason, 54 redundant clones are gone, and `CONTRIBUTING.md` says which
lints of the table stay off and why. The behavior does not change.
- Performance: on aarch64, the Q8_0 fast decode path uses the register-tiled
attention kernel. Decode is faster at long contexts, and the output stays
bit-identical.
- Native console: GPUI Kit moves from 0.6.6 to 0.9.0. Lists, tables and
selectors now bounce at the scroll limit on macOS, the Kit default.
- GUI builds and the pinned development toolchain use Rust 1.100.0. The
headless MSRV stays at Rust 1.92.

### Fixed

Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Ember keeps these exceptions to the Google guide:

## Local validation

`rust-toolchain.toml` pins Rust 1.98.1, which the default GUI build needs;
`rust-toolchain.toml` pins Rust 1.100.0, which the default GUI build needs;
CI also checks the headless crate on the 1.92.0 MSRV. `scripts/ci_local.sh`
runs the model-free CI gates with the same flags as
`.github/workflows/ci.yml`:
Expand Down Expand Up @@ -230,7 +230,7 @@ you reviewed, for example `docs/...`, `fix/...`, `test/...`, or `perf/...`.

### 2. Build a baseline, then choose the smallest patch

Rust 1.98.1 is pinned by `rust-toolchain.toml`; the headless crate also
Rust 1.100.0 is pinned by `rust-toolchain.toml`; the headless crate also
builds on the 1.92.0 MSRV. No model is needed for the unit-test path. The default feature includes the gpui/Vulkan native console;
use the headless check when display/X11/ALSA development libraries are not
available:
Expand Down
Loading
Loading