Repository navigation
fix(factory): keep string @Inject tokens in partial mode and for more string forms - #610
Merged
Merged
Conversation
… string forms
- Partial compilation declares the token as a string (`deps: [{ token: "API_URL" }]`),
not a bare identifier that throws or does not parse.
- The last `@Inject` on a parameter decides whether its token is a string, as in ngtsc.
- A template literal with no substitutions, parentheses and TypeScript casts are
also string tokens.
- Add a strict compare fixture for a component with string tokens.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #599. That PR made
@Inject('TOKEN')work in full-mode component factories. This PR fixes three cases it left.@Inject('API_URL')deps: [{ token: API_URL }]: a bare name, so aReferenceErroron load, or invalid JS if the string has quotes or is emptydeps: [{ token: "API_URL" }]@Inject('a') @Inject(Svc)on one parameterɵɵdirectiveInject("Svc"): the string flag from the first@Injectwas never resetɵɵdirectiveInject(Svc): the last@Injectwins@Inject(`TPL`),@Inject(('X')),@Inject('X' as any)ɵɵinvalidFactoryDep(i)ɵɵdirectiveInject("TPL")/("X")Notes:
`TPL`). Oxc emits"TPL". The value at runtime is the same.Not changed:
@Inject('a' + 'b')still givesɵɵinvalidFactoryDep.@Inject(ns.Svc)on a component still falls back to the parameter type; that is how it worked before #599, and it is not a string token.Tests
tests/inject_string_token_test.rs: three new tests, one per row above.factory/component-inject-string-token. Its factory matches ngtsc. The fixture's only listed difference is the keptInject/Optional/Selfimport, already documented forsetClassMetadata.cargo test -p oxc_angular_compiler --all-features: 3491 passed.pnpm compare --fixtures: 1162 fixtures, 0 mismatches.pnpm test: 376 passed.pnpm checkpasses.🤖 Generated with Claude Code