Repository navigation
fix(log): keep Error details in logger fields - #583
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #577
Summary
logger.error('save failed', { error })logged"error":{}.name,message,stackandcauseare non-enumerable onError, soJSON.stringifydrops them.format()inpackages/void/src/runtime/log.tsnow passes a replacer toJSON.stringify. The replacer writes eachErroras its own enumerable fields plusname,message,stackandcause. This covers nested errors andcausechains. The{ msg, ...fields }shape is unchanged. An error that appears a second time (for exampleerror.cause = error) is written as{ name, message }, so serialization terminates and the other fields are kept.An error with its own
toJSONstill uses it, becauseJSON.stringifycallstoJSONbefore the replacer.Tests
New cases in
packages/void/test/unit/runtime-log.test.ts:Errorfields keepname,message,stackandcause.Errorsubclasses keep their own enumerable fields (status).causedoes not drop the other fields.vp test run packages/void/test/unit/runtime-log.test.ts: 3 failed, 12 passed without the fix; 15 passed with it.vp lintandvp fmt --checkare clean on the changed files.Docs
docs/reference/api/resources.mdnotes that you can pass a caughtErrorinfields.