Repository navigation
Pin oUF 14.2.1 and LibEditMode 19 - #86
Merged
Merged
Conversation
Bump oUF to c5ff6e4 and LibEditMode to b4816be in the fetch and test-setup scripts, and point the third-party notices at the new tags.
oUF's arena prep now calls C_CVar.GetCVarBool, so the snapshot picks it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
c5ff6e4) and LibEditMode to 19 (b4816be) inscripts/fetch-libs.shandscripts/setup-test-libs.shTHIRD_PARTY_NOTICES.mdat the new upstream tags (upstream license files are unchanged)Why
Both libraries were behind upstream. oUF 14.2.1 brings Forever fixes (the stagger guard, leader tags, the master looter events, secret-scrubbed raid GUIDs). LibEditMode 19 adds an X/Y coords box to the Edit Mode dialog.
Fixes #81
How to test
In game:
/reloadshould show no Lua errors and the frames should appear. In Edit Mode, select a frame: the X/Y coords box shows above the dialog. Arrow keys nudge (Shift ×10, Alt ×0.1), and dragging, snapping and Reset position all still save per layout.Worth a closer look
tests/helpers.luareplaces oUF and LibEditMode with stubs, so the green run only shows our code is fine. The in-game check above is the real proof, and it's still pending.HEADER_COLON. Our Forever API snapshot doesn't list global strings. If the client lacks it, selecting a frame in Edit Mode throws an error.updateRaidnow callsscrubsecretvalues(ClickGrid headers hit it). The call is in the Forever API snapshot.fetch-libs.shandsetup-test-libs.shwere checked to produce byte-identical lib trees.