Skip to content

Pin oUF 14.2.1 and LibEditMode 19 - #86

Merged
voshond merged 2 commits into
mainfrom
unit-3-update-ouf-libeditmode
Nov 9, 2026
Merged

voshond merged 2 commits into
mainfrom
unit-3-update-ouf-libeditmode

Conversation

@voshond

@voshond voshond commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

What

  • Pin oUF to 14.2.1 (c5ff6e4) and LibEditMode to 19 (b4816be) in scripts/fetch-libs.sh and scripts/setup-test-libs.sh
  • Point THIRD_PARTY_NOTICES.md at the new upstream tags (upstream license files are unchanged)
  • No addon code changes: the oUF and LibEditMode API our code uses is unchanged

Why

Both libraries were behind upstream. oUF 14.2.1 brings Forever fixes (the stagger guard, leader tags, the master looter events, secret-scrubbed raid GUIDs). LibEditMode 19 adds an X/Y coords box to the Edit Mode dialog.

Fixes #81

How to test

rm -rf UnitFrames/Libs UnitFrames_Media/Libs && scripts/setup-test-libs.sh
luajit tests/run.lua -j            # 1075 passed
scripts/install.sh                  # or --host arch

In game: /reload should show no Lua errors and the frames should appear. In Edit Mode, select a frame: the X/Y coords box shows above the dialog. Arrow keys nudge (Shift ×10, Alt ×0.1), and dragging, snapping and Reset position all still save per layout.

Worth a closer look

  • The tests don't run the real libraries. tests/helpers.lua replaces oUF and LibEditMode with stubs, so the green run only shows our code is fine. The in-game check above is the real proof, and it's still pending.
  • LibEditMode 19's coords box builds its labels with the global HEADER_COLON. Our Forever API snapshot doesn't list global strings. If the client lacks it, selecting a frame in Edit Mode throws an error.
  • oUF's updateRaid now calls scrubsecretvalues (ClickGrid headers hit it). The call is in the Forever API snapshot.
  • fetch-libs.sh and setup-test-libs.sh were checked to produce byte-identical lib trees.

Bump oUF to c5ff6e4 and LibEditMode to b4816be in the fetch and test-setup scripts, and point the third-party notices at the new tags.
@voshond voshond self-assigned this Nov 9, 2026
oUF's arena prep now calls C_CVar.GetCVarBool, so the snapshot picks it up.
@voshond
voshond merged commit 1a3bd06 into main Nov 9, 2026
1 check passed
@voshond
voshond deleted the unit-3-update-ouf-libeditmode branch November 9, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pinned libraries are behind upstream

1 participant