Repository navigation
Healer buffs out of the box - #91
Merged
Merged
Conversation
Research on rank IDs, RAID_IN_COMBAT coverage on Forever, HealKit/EllesmereUI/HealBot approaches, and a plan for a generated buff catalogue, rank-proof slots, default heal filter and presets.
spell_catalog.py now also emits Tracking/BuffCatalog.lua: HoT, absorb, proc, external, defensive and raid-buff families with every rank (skill-line and RaidInCombat sets), a byId lookup and the RaidInCombat set. Adds SpellAuraVisibility to the pinned snapshot.
Slot spell IDs expand through the buff catalogue when building native candidates and drawing samples; saved text stays as typed. Adds BuffSpells (Family, Expand, Roots) and a "Track a spell" family picker that writes the family root ID.
New catalogue-backed buff filter (HELPFUL|PLAYER + the player's class hot/absorb/proc families as includeSpellIDs), compared by value before the native candidate setter. ClickGrid member buffs default on with it and no duration cap; previews count your class's sample heals as yours. RAID_IN_COMBAT choice relabelled. Adds a druid member-cell proof scenario.
Replaces the in-game verification with a source check of HealKit, HealBot, EllesmereUI, LibHealComm and the Forever UI.
Named catalogue buff sets (My heals & shields, Externals & defensives, Raid buffs) as filter choices and ClickGrid presets that resolve to filter + every rank ID. A Healing buffs page applies a set to outside, inside corner slots or the aura bar, with sample-fed showcase cards for all three. Adds proof scenarios per placement.
Extras step offers "Heals on group frames" with Outside / Corners / Aura bar when ClickGrid is loaded and the Healer look or a healing class is picked. It writes My heals & shields into the pending style as a full ClickGrid section, only when chosen; off drops only the heals set. Extras can now be conditional and carry a choice.
The design doc no longer asks for an in-game check: a Verification section records the user's waiver of 2026-11-11 (UNIT-22, plan decision no-ingame-acceptance), with the source check plus clickgrid_member_heals_spec as coverage. The spec now also checks a priest's include IDs on live cells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A healer's own HoTs and shields show on ClickGrid party/raid cells with default settings, whatever rank they cast, and nobody has to type spell IDs. Then named buff presets, a Workbench "Healing buffs" page with live showcases for the three placements, and an onboarding tile that offers it all. This is the UNIT-12 epic: it adopts its sub-tasks UNIT-13 to UNIT-17. The design is in todos/10-design-healer-buffs.md, committed only on the aura-display-onboarding branch (fde8115) so far.
Healer HoTs and shields show by default
Buff presets, showcases and onboarding
One pull request for the plan: each milestone was merged into
plan/healer-buffs-out-of-the-boxwhen it passed.