Skip to content

Add global buff and debuff settings and fix the preview - #94

Merged
voshond merged 1 commit into
mainfrom
beluga-aura-icon-settings
Nov 11, 2026
Merged

voshond merged 1 commit into
mainfrom
beluga-aura-icon-settings

Conversation

@voshond

@voshond voshond commented Nov 11, 2026

Copy link
Copy Markdown
Owner

What

  • Global Settings > Aura Icons now also has Buffs, Debuffs and Spacing & Shared Side sections: which auras, how many, size, side, alignment, growth, gap, offsets, swipe.
  • Every frame's external icons (and ClickGrid) inherit these unless the frame has its own value. Only the on/off switch stays per frame; the embedded row and priority icons keep their own layout.
  • The Global Settings preview flows its sample icons along the bar's width (it used to stack them in one column) and no longer forces its own icon counts and sizes, so it shows exactly the shared values.

Why

The global Aura Icons page only covered text, colours and the icon frame, so buff and debuff settings had to be repeated on every frame, and its preview was broken.

How to test

luajit tests/run.lua -j
bash scripts/proof.sh workbench-global-aura target-global-aura

In game: /uf wb > Global Settings > Aura Icons, change a Buffs or Debuffs value and check the preview and the live frames follow; override it on one frame and check that frame keeps its own value.

Worth a closer look

  • Frame defaults still beat the shared value: the main frames keep their own side and gap, and pet, target of target and ClickGrid keep their own sizes and counts.
  • Saved Workbench preview state (UnitFramesWorkbenchDB entries) is reset once, because the old theme preview state carried forced icon counts. Saved styles are untouched.
  • tests/fixtures/schema_snapshot.txt only gains theme entries and inherit fields; resolved unit styles are unchanged.
  • Not verified in game: combat restyling and live unit changes. Proof is mocked rendering.

UI proof

Rendered by scripts/proof-publish.sh from 036037f.

workbench-global-aura-icons (shared defaults)

workbench-global-aura-icons

workbench-global-aura-icons-changed (shared debuff size 34, 6 buffs, spacing 4)

workbench-global-aura-icons-changed

target-global-aura-icons

target-global-aura-icons

The Aura Icons page in Global Settings now also carries the Buffs, Debuffs and spacing options of the external icons; every frame and ClickGrid inherits them unless it has its own value, and only the on/off switch stays per frame. The embedded row keeps its own options. The theme preview no longer overrides icon counts and sizes and flows its icons along the bar's width instead of one column; saved Workbench preview state is reset once for that.
@voshond voshond self-assigned this Nov 11, 2026
@voshond
voshond merged commit 4b5ba42 into main Nov 11, 2026
1 check passed
@voshond
voshond deleted the beluga-aura-icon-settings branch November 11, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant