Repository navigation
Add global buff and debuff settings and fix the preview - #94
Merged
Merged
Conversation
The Aura Icons page in Global Settings now also carries the Buffs, Debuffs and spacing options of the external icons; every frame and ClickGrid inherits them unless it has its own value, and only the on/off switch stays per frame. The embedded row keeps its own options. The theme preview no longer overrides icon counts and sizes and flows its icons along the bar's width instead of one column; saved Workbench preview state is reset once for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The global Aura Icons page only covered text, colours and the icon frame, so buff and debuff settings had to be repeated on every frame, and its preview was broken.
How to test
In game:
/uf wb> Global Settings > Aura Icons, change a Buffs or Debuffs value and check the preview and the live frames follow; override it on one frame and check that frame keeps its own value.Worth a closer look
UnitFramesWorkbenchDBentries) is reset once, because the old theme preview state carried forced icon counts. Saved styles are untouched.tests/fixtures/schema_snapshot.txtonly gains theme entries andinheritfields; resolved unit styles are unchanged.UI proof
Rendered by
scripts/proof-publish.shfrom036037f.workbench-global-aura-icons (shared defaults)
workbench-global-aura-icons-changed (shared debuff size 34, 6 buffs, spacing 4)
target-global-aura-icons