Repository navigation
Bump wow-ui-testing to forever 70888 and fix stale specs - #95
Merged
Merged
Conversation
Pins the library with the 70888 client source and inline |T/|A proof icons. Regenerates the spell catalogue (Pounce Bleed ranks now share family 9007), the proof atlas table and the schema snapshot hashes that follow from it.
The library's snapshot lists strsplit, hooksecurefunc, date and friends under lua.builtins (API.EngineLua); count them as client functions, as MagicMap does.
A parent level change re-levels every child to parent+1, which put the empty-target frame level with the target bar. Re-assert its level on Apply.
With real layout in the mock it became a visible snap candidate, so the candidate count and the chosen snap depended on pairs order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.wut-versionto the wow-ui-testing build with the forever 1.60.1.70888 client source and inline|T/|Aicons in proofs (Draw inline texture and atlas escapes in proofs wow-ui-testing#4, Add spell drops to the ClickGrid binding editor #5, tag v0.1.5).API.EngineLua:strsplit,hooksecurefunc,date…), as MagicMap already does.Apply.pairsorder (that's the flake). These cases now leave it out.Why
The library pin was 4 releases behind, so proofs missed the inline-icon fix and the mock ran against an old client build.
How to test
bash scripts/fetch-wut.sh && bash .wut/scripts/update-client-source.sh --sync python3 -B scripts/spell_catalog.py --check bash scripts/run-tests.sh -j bash scripts/proof.shLocally: 1075 passed, 29 proof snapshots, no placeholder art. The Edit Mode spec ran green 6 times in a row.
Pinned to wow-ui-testing
v0.1.5(a3e77ba, the merged #5).Proof
CI renders the proofs and uploads them as the
ui-proofartifact on this PR.