Repository navigation
Keep mouseover highlight inside the frame border - #97
Merged
Merged
Conversation
The wash covered the whole unit button, so it showed past chamfered and soft border edges. It now insets by the border padding, like the bars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The mouseover wash from #96 covered the whole unit button. Party/raid bars have no border, so it looked right there. Bordered frames (player, target, focus…) use chamfered or soft border art with transparent corners and edges, so the wash showed past the border.
Fix
UnitFrame:Layoutnow insets the hover host byBackdrop.Padding(border), the same inset the bars use. Separate padding is respected. Frames without a border stay flush, so ClickGrid is unchanged.Tests
hover_speccase: the wash is inset by uniform and separate padding, and flush with the border off.luajit tests/run.lua -j: 1083 passed.