Repository navigation
DOC: name the write_gcps parameter as the signature defines it - #960
Open
dylanpulver wants to merge 1 commit into
Open
dylanpulver wants to merge 1 commit into
dylanpulver wants to merge 1 commit into
Conversation
write_gcps takes `gcps`, and the Parameters entry called it `gcp`, so write_gcps(gcp=...) raises TypeError. The description already reads "The Ground Control Points", plural.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XRasterBase.write_gcpstakesgcps, but the Parameters entry calls itgcp, sowrite_gcps(gcp=...)raises TypeError for anyone following the docstring. The description already reads "The Ground Control Points to integrate to the dataset", plural.One line, no behaviour change.
pre-commit run --files rioxarray/rioxarray.pypasses black, isort, blacken-docs and flake8.I left
docs/history.rstalone, since a one-line docstring name does not look like it belongs there, but say the word and I will add an entry.