Skip to content

Skip non-map actions in declarative push messages - #437

Merged
saschanaz merged 1 commit into
w3c:gh-pagesfrom
JinDX:guard-declarative-push-action-maps
Nov 12, 2026
Merged

saschanaz merged 1 commit into
w3c:gh-pagesfrom
JinDX:guard-declarative-push-action-maps

Conversation

@JinDX

@JinDX JinDX commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Check that each actions entry is a map before reading its keys. A payload with null followed by a valid action can then skip null and keep the valid action.


Preview | Diff

@saschanaz saschanaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saschanaz

Copy link
Copy Markdown
Member

I think this is not just editorial so would be nice to sign the IPR

@JinDX

JinDX commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

I think this is not just editorial so would be nice to sign the IPR

Thanks, @saschanaz. @siusin, could you send me the link to submit the non-participant licensing commitment for this PR?

@w3cbot

w3cbot commented Nov 12, 2026

Copy link
Copy Markdown

saschanaz marked as non substantive for IPR from ash-nazg.

@saschanaz

Copy link
Copy Markdown
Member

Actually it's not substantive either, so I just marked it so.

@saschanaz
saschanaz merged commit a236755 into w3c:gh-pages Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants