Repository navigation
Match docs to the window, trim check loops - #164
Merged
Merged
Conversation
The rebrand left the docs behind the renamed window, and three claims contradicted the code (INCONSISTENCIES I-01..I-03). A processor whose Accepts list is null is skipped during discovery, so it is never offered, not offered for every type. Splitter widths persist through EditorPrefs keys, never with the settings asset, so the pane-width clause drops out of the shared-state sentence. The persistence toggle reads Persist State in Settings Asset on screen, so the docs now name that label and describe the default as off. The settings tooltip had the two save locations swapped; it now matches the field. The row actions are the four buttons on each row, not controls above the object list, and menu paths read Tools > Wallstop Studios > DxVisualizer per the 147 rename. Fixes #153. Progresses #149 and #146.
The llm-lint workflow's slowest step is the self-test suite (71s of the 97s Windows job), and it ran on every triggered push or PR even when only docs or C# changed, which cannot affect any self-test outcome. A shared scope module now decides from the changed paths; the workflow resolves the base sha, fetches it shallowly when checkout did not include it, and runs the suite only when the harness surface (scripts, .llm, .github, .devcontainer, .config, manifests) moved. The verdict fails safe: an unresolvable base always runs the suite. Coverage is unchanged - every surface change still runs the full suite on both operating systems.
The validation ladder reruns whole-tree formatting, every harness lint, the full self-test suite, and npm pack for any edit, so a one-line fix costs around a minute per iteration. npm run check:fast now classifies the paths changed since origin/main and runs only the groups that can fail: CSharpier plus the C# source lints for .cs, prettier plus the changelog cap for .md, the harness lints and self-tests for the harness surface, npm pack for the package payload, and the assembly, release, and line-ending guards for their own files. It reuses the scope module the CI skip logic uses, so both verdicts stay identical. The full ladder still gates review.
The rebrand renamed the product and menu paths, and the extending page was missing the handoff note that namespaces, types, and assemblies are unchanged, so readers could not tell whether their code needed edits. Refs #149.
This was referenced Oct 10, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae16683. Configure here.
Bugbot on PR 164 found that the plan fed every changed .cs and .md path to csharpier and prettier, including deletions and the old path of a rename, so the first delete or rename on a branch broke check:fast for every later iteration. Group triggers still see the full changed list - deleting a harness file must keep running the self-tests, and deleting the changelog must fail closed per its contract - but the formatter lists now keep only paths that exist on disk. Three fixture cases pin the shape: working-tree deletions, committed deletions, and the rename old-path. The pattern joins the forbidden list with the other guards-that-lie rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLOSURE: LLM-GENERATED TEXT
Why: The docs contradicted the window in three behavior claims, and every PR paid the harness self-test suite even when it could not fail.
What:
npm run check:fastfor changed-file local validationFixes #153. Refs #149, #146.
Type of Change
Checklist
Note
Low Risk
Changes are mostly documentation and CI/dev harness scripts; the only runtime edit is a settings tooltip string with no behavior change.
Overview
Aligns user-facing docs and settings copy with actual window behavior, and speeds up local and CI validation when harness tooling is untouched.
Docs and UI copy: README and
docs/are updated for the DxVisualizer menu/branding while noting code identifiers stayDataVisualizer. Processor docs now state that missingAcceptsmeans the processor is never offered (matchingDataVisualizer.cs). Persistence text uses Persist State in Settings Asset and correct on/off semantics; pane widths are documented as always stored in editor preferences. The settings asset tooltip is corrected inDataVisualizerSettings.cs.Faster checks: Adds
npm run check:fast(scripts/fast-check.ps1) to format/lint only changed paths sinceorigin/main(or merge-base), skip harness self-tests when the harness surface is unchanged, and avoid passing deleted or rename-old paths into formatters. CI gains the same skip viaharness-scope.psm1,should-run-self-tests.ps1, and a conditional step inllm-lint.yml. Harness scope and fast-check planning are covered by new self-tests; agent guidance and a forbidden-pattern row document the deletion/rename filtering rule.Reviewed by Cursor Bugbot for commit e6fbad7. Bugbot is set up for automated code reviews on this repo. Configure here.