Preserve all windows/workspaces on close, not just the last one

[Jordy098]

Summary

• Terminal blocks already persist their cwd (cmd:cwd meta, set via the OSC 7 shell-integration handler) and restore it when their shell relaunches — but that only helps if the Block/Workspace survives in the DB.
• Closing a window while other windows are still open (or with window:savelastwindow off) always deleted that window's workspace/tabs/blocks on close, discarding any persisted cwd along with it. Only a single-window full app quit reliably survived a restart.
• Adds a new setting window:restoreallwindows (default true) so every window is preserved on close, not just the last one, letting all previously-open terminal paths come back after a full app restart.

Test plan

• Open 2+ windows, cd to different directories in each terminal block and let the prompt render (fires OSC 7 → cmd:cwd)
• Close one window via the close button (not full quit) — its workspace should remain in the DB instead of being deleted
• Quit the app fully and relaunch
• Confirm all windows reopen with their terminals in the same working directory as before
• Repeat with window:restoreallwindows set to false to confirm the legacy single-window behavior still works

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1795c356-e47a-47a9-9a1f-c2231dc32d89

📥 Commits

Reviewing files that changed from the base of the PR and between c99022c and 92be0c8.

📒 Files selected for processing (7)

• docs/docs/config.mdx
• emain/emain-window.ts
• frontend/types/gotypes.d.ts
• pkg/wconfig/defaultconfig/settings.json
• pkg/wconfig/metaconsts.go
• pkg/wconfig/settingsconfig.go
• schema/settings.json

---

Walkthrough

This PR introduces a new boolean configuration key, window:restoreallwindows, which controls whether all open windows are preserved and restored on next launch. The change adds the key to the Go settings struct, config key constants, default settings JSON, JSON schema, TypeScript type definitions, and documentation. The window close handler in the Electron main process is updated to compute window preservation based on this new setting in combination with the existing window:savelastwindow setting.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

Not applicable; changes are primarily configuration/schema additions and a small conditional logic refactor.

Related PRs

None identified.

Suggested labels: enhancement, configuration

Suggested reviewers: none identified

_{🐰 A whisker-twitch of a config so small,
One bool to save the windows, one and all,
Schema, types, and docs align,
Close handler learns a new design,
Hop along, the settings stand tall.}

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: preserving all windows and workspaces on close instead of only the last window.
Description check	✅ Passed	The description directly matches the implemented change and test plan for the new window restoration behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.1)

frontend/types/gotypes.d.ts

File contains syntax errors that prevent linting: Line 1880: Expected a property, or a signature but instead found '#'.; Line 1880: Expected an expression, or an assignment but instead found ':'.; Line 1880: Expected an expression but instead found ']'.; Line 2193: Expected a statement but instead found '}'.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[andrewinalaska]

Traced this through fully (not a bot finding — I've been working in this exact area for #3512-3514 and wanted to check for interaction effects). I think there's a real regression here, worth a look before merge.

The issue: deleteAllowed (set in the close handler, emain-window.ts) is the only thing that gates whether WindowService.CloseWindow(windowId, true) gets called from the closed handler. And wcore.CloseWindow (pkg/wcore/window.go) is the only code path in the entire repo that removes an entry from client.WindowIds — confirmed by grepping every reference to client.WindowIds; every other one only appends (on window creation) or reorders (on focus), never removes.

With this PR's new preserveThisWindow condition and window:restoreallwindows defaulting to true, deleteAllowed is essentially never set to true anymore for an ordinary window close (only a full app quit still hits the paths that eventually clean things up). That means wcore.CloseWindow never runs for a plain "click the X on one window while others stay open" action, which means:

1. That window's ID is never removed from client.WindowIds.
2. Its window/workspace DB rows are never deleted (DeleteWorkspace/DBDelete never run).
3. On every subsequent app launch, relaunchBrowserWindows() iterates clientData.windowids and faithfully reopens it — forever, since nothing else ever prunes that list.

So with the new default, manually closing a window doesn't really "close" it in the sense a user would expect — it just hides it until the next launch, and it keeps coming back indefinitely, even windows closed weeks ago. I don't think that's the intended behavior described in the PR body (which frames this around app restart restoring what was open, not "closed windows resurrect forever"). It might be worth distinguishing "window closed individually by the user" from "window still open when the app quit" — e.g. only preserving windows that are still open at actual app-quit time, rather than preserving every window that has ever been closed while restoreallwindows is on.

Happy to be wrong here if I'm missing some other cleanup path — but I traced every client.WindowIds mutation site and this was the only removal path I could find.