Repository navigation
Include 'latest_suspension' in /mine wiki response - #1307
Merged
Merged
Conversation
tarrow
force-pushed
the
wiki-suspensions-3
branch
from
October 19, 2026 14:13
b5f317a to
85ca889
Compare
tarrow
changed the title
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
3 times, most recently
from
October 20, 2026 23:09
d411066 to
e3e7c39
Compare
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
from
October 20, 2026 23:30
e3e7c39 to
acf581a
Compare
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
from
October 20, 2026 23:46
acf581a to
d068864
Compare
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
from
October 20, 2026 23:52
d068864 to
44c1c9d
Compare
outdooracorn
changed the base branch from
wiki-suspensions-2
to
ollie-improve-factory-and-tests
October 20, 2026 23:52
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
from
October 21, 2026 00:06
44c1c9d to
b7c06b0
Compare
tarrow
force-pushed
the
wiki-suspensions-3
branch
from
October 22, 2026 16:38
b7c06b0 to
61c0002
Compare
tarrow
commented
Oct 22, 2026
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
from
October 23, 2026 15:27
61c0002 to
ed66b58
Compare
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
3 times, most recently
from
October 27, 2026 12:57
beeda8c to
e8d5d3d
Compare
outdooracorn
changed the base branch from
ollie-improve-factory-and-tests
to
remove-unsuspension-logic
October 27, 2026 12:58
outdooracorn
changed the title
/mine wiki response
outdooracorn
marked this pull request as ready for review
October 27, 2026 14:38
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
2 times, most recently
from
October 27, 2026 14:52
607a9f7 to
5f0036d
Compare
outdooracorn
force-pushed
the
wiki-suspensions-3
branch
from
October 27, 2026 15:07
5f0036d to
efdfb48
Compare
outdooracorn
previously approved these changes
Oct 29, 2026
tarrow
commented
Nov 1, 2026
tarrow
left a comment
tarrow
left a comment
Contributor
Author
There was a problem hiding this comment.
"approved" (but it's my PR)
outdooracorn
approved these changes
Nov 1, 2026
This commit adds a simple relationship to the Wiki model to include just the latest suspension type suspension action. It then includes this in the `/mine` endpoint for consumption by the UI Bug: T441452
This adds an Accessor[0] to allow the `/mine` api to pass on if a given suspension is active or not for use in the front end. This prevents having to do date calculations in the UI. [0] https://laravel.com/framework/docs/11.x/eloquent-mutators#building-value-objects-from-multiple-attributes
* Put properties before methods * Put protected properties and methods before public ones
tarrow
force-pushed
the
wiki-suspensions-3
branch
from
November 2, 2026 08:30
4d396a7 to
a252541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the Platform UI to display the state of Wikis on the Wiki Manager's dashboard.
Add a simple
latestSuspensionrelationship to theWikimodel to get the latest wiki suspension, ornullwhen there are no suspensions. Eager load this relationship in theWikisControllerto include thelatest_suspensionfield in responses of the/wiki/mineendpoint.Add an
active"accessor"1 toWikiSuspension, which returns whether theactive_fromdatetime has been reached. Include it in the$appendsarray so that serialized representations of the model include this boolean by default2. This centralizes the calculation and avoids duplicating it in the UI.Bug: T441452