Skip to content

Lock user on wiki creation to avoid race request possibly exceeding quota #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
addshore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lock user on wiki creation to avoid race request possibly exceeding quota #1324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/Http/Controllers/WikiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use App\Jobs\ProvisionWikiDbJob;
use App\KnowledgeEquityResponse;
use App\QueryserviceNamespace;
use App\User;
use App\Wiki;
use App\WikiDb;
use App\WikiDomain;
Expand Down Expand Up @@ -87,6 +88,10 @@ public function create(Request $request): Response {

// TODO create with some sort of owner etc?
DB::transaction(function () use ($user, $request, &$wiki, &$dbAssignment, $submittedDomain, $rawProfile, $rawKnowledgeEquityResponse): void {
// Lock the user before any reads establish a repeatable-read snapshot.
// Creation always locks in this order: user, wiki DB, then QS namespace.
$user = User::whereKey($user->getKey())->lockForUpdate()->firstOrFail();

$dbVersion = Config::get('wbstack.wiki_db_use_version');
$wikiDbCondition = ['wiki_id' => null, 'version' => $dbVersion];

Expand All @@ -101,7 +106,7 @@ public function create(Request $request): Response {
$numWikis = $user->managesWikis()->count() + 1;
$maxWikis = config('wbstack.wiki_max_per_user');

if (config('wbstack.wiki_max_per_user') !== false && $numWikis > config('wbstack.wiki_max_per_user')) {
if ($maxWikis !== false && $numWikis > $maxWikis) {
abort(403, "Too many wikis. Your new total of {$numWikis} would exceed the limit of {$maxWikis} per user.");
}

Expand Down
Loading