Repository navigation
feat(cc-widgets): wire AI summary workflows - #750
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57dfea3335
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'on-recording-toggle', | ||
| 'conference-enabled', | ||
| ]); | ||
| expectObservedAttributes(AI_ASSISTANT_TAG, [ |
There was a problem hiding this comment.
In the cc-widgets Jest/jsdom suite, WebAIAssistant still declares seven wellness props in src/wc.ts (onWellnessBreakOffered through wellnessBreakOverlayTarget), and r2wc includes each declared prop in observedAttributes. This newly added exact-equality assertion omits all of them, so the cc-widgets unit suite has a guaranteed failure; include the existing dashed wellness attributes or avoid asserting the unrelated element here.
Useful? React with 👍 / 👎.
Use SDK summary types directly and send only changed structured sections. Guard superseded request results, pair task listener cleanup, and require the original task for post-call submission. Repair the lockfile for immutable installs.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
c18c8e9 to
f47d8bd
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f47d8bd to
f2eef6e
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f2eef6e to
0849d99
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
0849d99 to
321bd0c
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Reuse adaptive summary cards and shared copy and feedback actions. Match Momentum consult, transfer, and wrap-up interactions, preserve staged selections and summary exclusion, and synchronize SDK response handling, regression tests, and module contracts.
321bd0c to
db0855f
Compare
Kesari3008
left a comment
Kesari3008
left a comment
There was a problem hiding this comment.
Please test thoroughly not just summary feature but also suggested responses and consult and transfer flows because there are too many changes on the existing code impacting existing features and make a vidcast of that
| {renderLauncherButton()} | ||
| </div> | ||
| ) : ( | ||
| renderLauncherButton() |
There was a problem hiding this comment.
This comment is still not addressed
| method: 'copySuggestion', | ||
| method: 'copyToClipboard', | ||
| }); | ||
| return false; |
There was a problem hiding this comment.
Please test these changes for Suggested Responses as well because it gets used there too
| // Stash callbacks in refs so the render effect only re-runs when the card | ||
| // itself changes — fresh inline parent callbacks would otherwise force a | ||
| // full re-parse and re-fetch of every image on each render. | ||
| const onUserActionRef = useRef(onUserAction); |
There was a problem hiding this comment.
This code is related to suggested responses also and these changes might impact the existing feature to break. So either test the feature and ensure nothing breaks or verify these changes
| {AI_ASSISTANT_SUMMARY_MESSAGES.editSummary} | ||
| </Button> | ||
| ) : null} | ||
| {showCopy ? ( |
There was a problem hiding this comment.
Would there ever be a scenario where copy option is not there so evaluate if we really need this condition
github-actions
Bot
removed
the
validated
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-actions
Bot
removed
the
validated
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f3387ecf2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (aiSummary?.midCall && aiSummary.midCall.state !== 'omitted') { | ||
| setAgentMenu((menu) => (menu && !menu.hasSummary ? {...menu, hasSummary: true} : menu)); | ||
| } |
There was a problem hiding this comment.
When TASK_FEATURE_ENABLEMENT turns midCallEnabled on while a telephony Consult/Transfer menu is already open, openAgentMenu has already run under the disabled flags, so its request was skipped or returned without creating an entry. This effect only latches hasSummary; the newly projected view therefore stays in generating until the agent closes and reopens the menu. Issue the matching request once when this transition occurs.
Useful? React with 👍 / 👎.
| if (hasIncomingContent && listRef.current) { | ||
| listRef.current.scrollTop = 0; | ||
| } | ||
| }, [hasIncomingContent]); |
There was a problem hiding this comment.
When a second TASK_MID_CALL_SUMMARY_RECEIVED arrives for the active interaction while the assistant is open after real-time-assist replies, children was already truthy, so this dependency does not change; chatEntries.length and status also remain unchanged. Because receiver cards are inserted before the chat and the open chrome suppresses the summary toast, the new card can remain offscreen with no notification. Drive this effect from receiver content identity or count rather than only child presence.
Useful? React with 👍 / 👎.
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Reuse assistant card surfaces and align wrap-up copy and suggestion chips. Use registration config until task enablement arrives, without summary storage.
a1b1dcb to
9d33ae2
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Thank you for your contribution! |
COMPLETES CAI-8657 and CAI-8658
This pull request addresses
Agents need conversation context when receiving a consult or transfer and when wrapping up a call. This PR adds those summary workflows to widgets and fixes incoming-summary visibility and layout.
by making the following changes
Change Type
The following scenarios were tested
The testing is done with the amplify link
Full repository unit tests, lint and build passed; sample TypeScript checks passed.
Summary regression coverage includes direct open/restore, toast actions, history, feedback, long-summary scrolling and assistance continuity. The assistant component suite passes 88 tests and the assistant widget suite passes 80 tests, including TypeScript.
Live integration testing covered included, edited and excluded summaries, consults, transfers, cancellation and wrap-up.
Compared incoming summaries with Agent Desktop and checked navigation, timestamps and compact/full-width layouts. Manual testing used the local integration build; Amplify validation is pending.
The GAI Coding Policy And Copyright Annotation Best Practices
GAI was not used (or, no additional notation is required)
Code was generated entirely by GAI
GAI was used to create a draft that was subsequently customized or modified
OpenAI Codex assisted with implementation, regression tests and review.
Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
Tool used for AI assistance (GitHub Copilot / Other - specify)
This PR is related to
Checklist before merging
Local unit suites passed with the existing skipped tests unchanged. Test results and screenshots are recorded locally; the shared testing-document update and Amplify validation are not marked complete.
Make sure to have followed the contributing guidelines before submitting.