Repository navigation
ci(codecov): gate the patch status with an explicit 95% target - #24
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
coverage.status.patch.default.targetwasauto. Codecov resolvesautofrom the base commit's coverage report. The org CI workflow atwebinertia/.github,.github/workflows/continuous-integration.yml, runs onpull_requestonly, so a default branch can have no coverage report at all.That leaves the patch gate in one of two bad states:
Either way the gate is not measuring the diff.
Change
target: autobecomestarget: 95%, with a comment recording why. 95 matches the fleet mutation gate (min_msiandmin_covered_msiare both 95 inwebware-ci.json).threshold: 0%andbase: autoare unchanged.coverage.status.project.defaultstaysauto: a single shared number cannot serve a fleet whose project coverage varies widely.Precedent
Already proven in webinertia/webware-tools#70 (merged as
4c3dbf0) and webinertia/asciidoc-php#19 (merged as32bd9f2). After that fix,asciidoc-php-multi-repo#8head7ea871freportscodecov/patchas "97.44% of diff hit (target 95.00%)" instead of "No report found to compare against".