Skip to content

Fix concurrency, detached document, and permissions checks in algorithms. - #337

Merged
domfarolino merged 4 commits into
mainfrom
fix-algorithms
Oct 13, 2026
Merged

domfarolino merged 4 commits into
mainfrom
fix-algorithms

Conversation

@markafoltz

@markafoltz markafoltz commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator
  • Eliminate a redundant check for an aborted signal.
  • Add a note about locking for the tool map before it's shown to the browser agent.
  • Add a check for a detached document before allowing a tool call on it.
  • Separate out steps to enumerate tools, from constructing RegisteredTools, as parse a JSON string cannot happen in parallel.
    • Maybe there's a different / cleaner way to handle this? But I think the parallel steps have to complete first outside of any script context, as they traverse the frame tree.

Preview | Diff

@markafoltz
markafoltz requested a review from domfarolino October 7, 2026 05:19
Comment thread index.bs Outdated
Comment thread index.bs Outdated
Comment thread index.bs
Comment thread index.bs Outdated
Comment thread index.bs Outdated
@domfarolino
domfarolino merged commit eada13b into main Oct 13, 2026
2 checks passed
@domfarolino
domfarolino deleted the fix-algorithms branch October 13, 2026 17:20
github-actions Bot added a commit that referenced this pull request Oct 13, 2026
…hms (#337)

SHA: eada13b
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants