Repository navigation
Replace UnknownError with specific DOMException types. - #339
Merged
Merged
Conversation
markafoltz
commented
Oct 7, 2026
markafoltz
requested review from
bwalderman and
domfarolino
and removed request for
domfarolino
October 7, 2026 17:07
domfarolino
self-requested a review
October 7, 2026 18:38
markafoltz
commented
Oct 7, 2026
domfarolino
reviewed
Oct 8, 2026
Collaborator
Author
|
@bwalderman PTAL and let me know if you have any feedback or suggested improvements! |
github-actions Bot
added a commit
that referenced
this pull request
Oct 8, 2026
SHA: b206dae Reason: push, by markafoltz Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
moh5544
approved these changes
Oct 16, 2026
beckysiegel
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 16, 2026
Spec change: webmachinelearning/webmcp#339 Updates ModelContext.executeTool() to reject with specific DOMException types instead of UnknownError. Implementation details: - Moves ScriptToolErrorCode into script_tools.mojom for target- renderer to browser-process reporting. - Introduces ExecuteRemoteScriptToolError in script_tools.mojom for reporting a subset of errors to calling frames. - Updates WPT to verify the new exception behavior. Bug: 509555636 Change-Id: I64d89525ac15af05250971a1ccc76e5964b41084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8546218 Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1720407}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2026
Spec change: webmachinelearning/webmcp#339 Updates ModelContext.executeTool() to reject with specific DOMException types instead of UnknownError. Implementation details: - Moves ScriptToolErrorCode into script_tools.mojom for target- renderer to browser-process reporting. - Introduces ExecuteRemoteScriptToolError in script_tools.mojom for reporting a subset of errors to calling frames. - Updates WPT to verify the new exception behavior. Bug: 509555636 Change-Id: I64d89525ac15af05250971a1ccc76e5964b41084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8546218 Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1720407}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2026
Spec change: webmachinelearning/webmcp#339 Updates ModelContext.executeTool() to reject with specific DOMException types instead of UnknownError. Implementation details: - Moves ScriptToolErrorCode into script_tools.mojom for target- renderer to browser-process reporting. - Introduces ExecuteRemoteScriptToolError in script_tools.mojom for reporting a subset of errors to calling frames. - Updates WPT to verify the new exception behavior. Bug: 509555636 Change-Id: I64d89525ac15af05250971a1ccc76e5964b41084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8546218 Reviewed-by: Fr <beaufort.francois@gmail.com> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1720407}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #323.
Preview | Diff