Skip to content

Fix inactive document unregistration's notification algorithm #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfarolino merged 2 commits into from
Oct 14, 2026
Merged

Fix inactive document unregistration's notification algorithm #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c17106
Fix inactive unregistration
domfarolino Oct 14, 2026
bae1872
Fix registerTool() too
domfarolino Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,13 @@ To <dfn for="model context">unregister a tool</dfn> given a {{ModelContext}} |mo
1. Let |targetDocument| be |modelContext|'s [=relevant global object=]'s [=associated
Document|associated <code>Document</code>=].

1. If |targetDocument| is not [=Document/fully active=], then return.
Comment thread
domfarolino marked this conversation as resolved.

Note: This can happen if a tool's {{ModelContextRegisterToolOptions/signal}} is aborted after
|targetDocument| has been removed from its [=navigable=], for example because its
<{iframe}> was removed. In that case, |targetDocument| has no [=node navigable=] from which to
find other documents to notify.

1. [=In parallel=], [=notify documents of a tool change=] given |targetDocument| and |exposed
origins|.

Expand Down Expand Up @@ -770,6 +777,13 @@ The <dfn method for=ModelContext>registerTool(<var>tool</var>, <var>options</var
</ol>
</div>

1. If |tool owner| is not [=Document/fully active=], then return [=a promise rejected with=] an
"{{InvalidStateError}}" {{DOMException}}.

Note: |tool owner| was already checked for being [=Document/fully active=] above, but serializing
Comment thread
domfarolino marked this conversation as resolved.
|tool|'s {{ModelContextTool/inputSchema}} can run script (e.g., a `toJSON()` method) that makes
|tool owner| no longer [=Document/fully active=], for example by removing its <{iframe}>.

1. If |options|'s {{ModelContextRegisterToolOptions/signal}} [=map/exists=] and is
[=AbortSignal/aborted=], then return [=a promise rejected with=] |options|'s
{{ModelContextRegisterToolOptions/signal}}'s [=AbortSignal/abort reason=].
Expand Down
Loading