This repository was archived by the owner on Aug 28, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 28, 2026. It is now read-only.
CSS modules with path which contains spaces does not work as expected #1626
Description
Bug report
Actual Behavior
generated src_render_js.js:
source render.js:
import * as styles from './space folder/render.module.css';
export function render() {
const el = document.createElement('div');
el.className = styles.text; // styles.text contains a space which breaks styling
document.getElementsByTagName('body')[0].appendChild(el);
el.innerHTML = 'hello, world';
}Expected Behavior
The generated class is src-space folder-render-module__text-WVNeAh which contains a space, but it's not possible to escape spaces, so the spaces in path should be changed to __ for example.
How Do We Reproduce?
https://github.com/JounQin/rspack-css-modules-spaces
Run pnpm dev:webpack
Activity
JounQin commentedon Dec 26, 2024
I tried to add space pattern into https://github.com/webpack-contrib/css-loader/blob/9dd19662bd2df289b75283ebf277d1875bbe5089/src/utils.js#L263 and then it works as expected, I'd raise a PR if it is accepted.
JounQin commentedon Dec 26, 2024
Not sure if #997 related.
JounQin commentedon Jan 13, 2025
@alexander-akait Any time to take a look?
alexander-akait commentedon Feb 4, 2025
Yeah, technically we have CSS.escape to escape special character before inserting them in JS and it works good for non space characters, but there are some limitation with the
classattributeBut https://html.spec.whatwg.org/multipage/dom.html#global-attributes:classes-2
Let's fix it
JounQin commentedon Apr 15, 2025
@alexander-akait I don't know how to add a test case for it easily, or we just change the
filenameReservedRegex?alexander-akait commentedon Apr 16, 2025
@JounQin I think we can change
filenameReservedRegexand look at our tests, if we don't broken anything we can merge and do a patch releaseJounQin commentedon Apr 16, 2025
@alexander-akait Here we go #1632