Skip to content

[WFLY-19812] move to junit 6 - #1205

Merged
emmartins merged 1 commit into
wildfly:mainfrom
emmartins:WFLY-19812-junit5
Oct 22, 2026
Merged

emmartins merged 1 commit into
wildfly:mainfrom
emmartins:WFLY-19812-junit5

Conversation

@emmartins

Copy link
Copy Markdown
Contributor

@emmartins emmartins changed the title [WFLY-19812] move to junit 5 [WFLY-19812] move to junit 6 Oct 1, 2026

@rhusar rhusar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about quickstarts in the JUnit 6 epic https://redhat.atlassian.net/browse/WFLY-21566 but that's mainly about migration from 4->6 and most of this is from 5->6 it seems. can you please review that Jira for the migration path proposed and see if this is in line with the recommendations or object and discuss if it is not?

I can do a review of this in full if you want, but very roughly, this looks good to me.

@emmartins

Copy link
Copy Markdown
Contributor Author

https://redhat.atlassian.net/browse/WFLY-21566

This mostly changes asserts and Before/After, think that's fine wrt your JIRA. Feel free to review :)

@rhusar rhusar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! No more Junit 4, fixed test scope, correct version management and correct 4->6 migration.

@rhusar

rhusar commented Oct 22, 2026

Copy link
Copy Markdown
Member

Nit post merge: lets update the wording in CONTRIBUTING.adoc to say "JUnit Jupiter"

@emmartins
emmartins merged commit d1e2d16 into wildfly:main Oct 22, 2026
479 of 480 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants