Repository navigation
docs(security): Rejustify internal reusable workflow SHA-pin exemption as risk acceptance - #101
Merged
Merged
Conversation
…n as risk acceptance Replace the factually incorrect Dependabot-support rationale with the two distinct cases: local ./ references are structurally immutable (resolved at the caller's commit), and cross-repo @main references are a deliberate risk acceptance for immediate fleet-wide propagation, not a security equivalent of SHA pinning. High-privilege consumers may pin a full-length SHA. Fix the README contradiction where consumer examples used @<pin-sha> while the note allowed @main. Signed-off-by: Yunseo Kim <git@yunseo.kim>
…mption rationale Regenerate the agent guide to cover the org profile, security companion docs, caller/reusable workflow pairs, Lefthook, and the lint/format stack. Align the SHA-pinning, consumer-exception, and anti-pattern entries with the rejustified internal reusable workflow exemption. Signed-off-by: Yunseo Kim <git@yunseo.kim>
Add the public org profile with the Windlass description, project table, and community links. Scope an MD026 exception to the H1 since "Inc." is an abbreviation, not trailing punctuation. Signed-off-by: Yunseo Kim <git@yunseo.kim>
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ss trust boundary The branch-name risk acceptance only holds for callers inside the organization. External callers of these public reusable workflows are outside the trust boundary and must pin a full-length commit SHA. Signed-off-by: Yunseo Kim <git@yunseo.kim>
… AGENTS.md Update the generation header to commit 381aac4, describe the repo's actual documentation and configuration formats (Markdown, YAML, JSON/JSONC, TOML, EditorConfig), and replace the overstated disabled-rule ranges with the exact list from .markdownlint-cli2.jsonc (MD011, MD021, and MD036 remain enabled). Also scope the consumer exception to Windlass callers. Signed-off-by: Yunseo Kim <git@yunseo.kim>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the factually incorrect rationale for the internal reusable workflow SHA-pin exemption ("Dependabot cannot propose updates") with a threat-model-accurate one, and fixes documentation contradictions around it.
docs/security/workflow-hardening.md: the exemption note is now anInternal Reusable Workflowssubsection separating the two cases. Local./references are structurally immutable (resolved at the caller's commit); cross-repo@mainreferences are a deliberate risk acceptance, not a security equivalent of SHA pinning. High-privilege consumers may pin a full-length SHA.README.md: the reusable-workflow note now states the risk-acceptance rationale; consumer examples use@main(they previously showed@<pin-sha>while the note allowed@main); the "Always pin" rollout note is aligned with the policy.docs/security/dependency-security.md: the consumer caller example uses@mainwith a link to the exemption policy.AGENTS.md: regenerated for the current repo state; SHA-pinning, consumer-exception, and anti-pattern entries aligned with the rejustified exemption.profile/README.md: new organization profile; MD026 exception scoped to the H1 because "Inc." is an abbreviation, not trailing punctuation.@main.Related Issues
Change Type
Changelog
Changelog update:
Checklist
General
type(scope): SummaryCI/Workflow Changes (if applicable)
Not applicable: no workflow or CI/CD configuration changes.
Protocol / Compatibility Impact
Testing
Describe test evidence:
bun run lint:mdreports 0 issues across all 19 Markdown files (including the MD026-scoped profile heading);bun run format:checkreports all files formatted; residual scan confirms no remaining@<pin-sha>placeholders or the old Dependabot rationale. Local cubic review ran before commit; the one remaining P2 (base64 badge SVG) is a disputed style preference on the standard shields.io custom-logo mechanism.Documentation
Rollout / Risk
Reviewer Checklist