Repository navigation
fix(llm): send Gemini structured output as JSON Schema - #254
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini structured output sends JSON Schema through
responseSchema, which uses the OpenAPI Schema message and rejects fields such asadditionalProperties. Send the unchanged caller schema throughresponseJsonSchema, supported by both Generative Language and Vertex AI.The nested closed-object regression fails before the change and passes afterward. Validation uses the official v0.3.59a runtime: the focused handler passes 34 cases, the full LLM suite passes 2,704 cases with 9 existing conditional integration skips, and scoped lint reports no issues. The focused smoke guard also passes on SQLite and PostgreSQL.
Public contracts, request options, routing, response shapes and stored data remain unchanged.