Skip to content

feat: Show offline files - WPB-29784 - #5517

Merged
ohassine merged 36 commits into
developfrom
show-offline-files-filter
Nov 13, 2026
Merged

ohassine merged 36 commits into
developfrom
show-offline-files-filter

Conversation

@ohassine

@ohassine ohassine commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-29784


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Add a new filter to show offline files

screen-20261111-104957-1794390584402.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine and others added 30 commits November 2, 2026 14:49
…offline-access

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/res/values/strings.xml
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/res/values/strings.xml
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
… auto-resume-download-after-network-loss

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt
Comment on lines +124 to +125
fadeIn(animationSpec = tween(durationMillis = 220, delayMillis = 90)) togetherWith fadeOut(
animationSpec = tween(durationMillis = 90)

@saleniuk saleniuk Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may get a MagicNumber warning 😅

…-filter

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/res/values/strings.xml
#	features/cells/stability/cells-debug.stability
#	kalium
Base automatically changed from offline-support-in-drive-screen to develop November 13, 2026 18:03
…-filter

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt
@ohassine
ohassine enabled stacked auto-merge November 13, 2026 18:11
@ohassine
ohassine disabled stacked auto-merge November 13, 2026 18:12
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.26%. Comparing base (4231ec7) to head (c40b573).

Files with missing lines Patch % Lines
...com/wire/android/feature/cells/ui/CellViewModel.kt 83.33% 2 Missing and 3 partials ⚠️
...kotlin/com/wire/android/datastore/UserDataStore.kt 0.00% 2 Missing ⚠️
...ire/android/feature/cells/ui/CellBulkActionsBar.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.75%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5517      +/-   ##
===========================================
+ Coverage    55.23%   55.26%   +0.03%     
===========================================
  Files          792      792              
  Lines        27649    27675      +26     
  Branches      4211     4219       +8     
===========================================
+ Hits         15271    15294      +23     
- Misses       11033    11035       +2     
- Partials      1345     1346       +1     
Files with missing lines Coverage Δ
...wire/android/feature/cells/ui/CellScreenContent.kt 0.00% <ø> (ø)
...ire/android/feature/cells/ui/CellBulkActionsBar.kt 0.00% <0.00%> (ø)
...kotlin/com/wire/android/datastore/UserDataStore.kt 0.00% <0.00%> (ø)
...com/wire/android/feature/cells/ui/CellViewModel.kt 66.61% <83.33%> (+1.05%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4231ec7...c40b573. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

  363 files  ± 0    363 suites  ±0   2m 26s ⏱️ -21s
3 120 tests +14  3 120 ✅ +14  0 💤 ±0  0 ❌ ±0 
3 132 runs  +14  3 132 ✅ +14  0 💤 ±0  0 ❌ ±0 

Results for commit c40b573. ± Comparison against base commit 4231ec7.

♻️ This comment has been updated with latest results.

@ohassine
ohassine enabled stacked auto-merge November 13, 2026 19:33
@github-actions

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
4cfd180cea48d840745bb5390b4e25d532f49b54 f0ba410f13ed318255a6ede126fc88b263d1a5e5

Is this intentional?

@github-actions

Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
4cfd180cea48d840745bb5390b4e25d532f49b54 f0ba410f13ed318255a6ede126fc88b263d1a5e5

Is this intentional?

@ohassine
ohassine added this pull request to the merge queue Nov 13, 2026
Merged via the queue into develop with commit a8a12f3 Nov 13, 2026
21 checks passed
@ohassine
ohassine deleted the show-offline-files-filter branch November 13, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants