Repository navigation
WPB-22954: migrate mls-commit-locks to PostGreSQL - #5415
Open
blackheaven wants to merge 6 commits into
Open
blackheaven wants to merge 6 commits into
blackheaven wants to merge 6 commits into
Conversation
zebot
added
the
ok-to-test
akshaymankar
left a comment
akshaymankar
left a comment
Member
There was a problem hiding this comment.
Why do we need to migrate these locks? Can we not just use some pg advisory locks instead of creating a table?
Contributor
Author
|
Agreed — no table needed. This is now a direct cutover to pg advisory locks (cc03ef9), reusing the same session-scoped advisory-lock mechanism as the domain-registration/team-feature dual-writes ( |
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
September 3, 2026 00:55
cc03ef9 to
abc0f6f
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
September 11, 2026 16:45
76ff607 to
4bf7ce9
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
September 24, 2026 07:30
4bf7ce9 to
3a03695
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
September 30, 2026 14:17
3a03695 to
f272542
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
October 20, 2026 17:29
f272542 to
92525e5
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
3 times, most recently
from
November 5, 2026 13:29
5f57cff to
d4eed5d
Compare
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
November 10, 2026 09:55
d4eed5d to
7532eba
Compare
Migrate the MLS commit-lock store (galley) from Cassandra to PostgreSQL using the dual-write + background-worker pattern, following the CodeStore recipe. The Postgres acquire replicates Cassandra's IF NOT EXISTS USING TTL via INSERT ... ON CONFLICT DO UPDATE WHERE expires_at < now() RETURNING, honoring both CAS mutual exclusion and TTL expiry (a pure DO NOTHING would leave an expired lock blocking its (group_id, epoch) forever, since Postgres has no TTL reaper). Adds Postgres/DualWrite/Migration interpreters, a migration flag + metrics, helm/config/docs wiring, schema migration, and an integration test.
Replaces the mls_commit_locks table + dual-write + backfill migration from the previous commit with a direct cutover to session-scoped pg advisory locks (Wire.MigrationLock try-lock). Contention answers stale-message immediately; crash safety comes from the holding connection dying instead of the 10-minute TTL. Deletes the MLSCommitLockStore.DualWrite/Migration modules, the background-worker migration job, the 20260804143320 SQL migration and all mlsCommitLocks/migrateMLSCommitLocks config knobs. The cassandra mls_commit_locks table becomes unread; dropping it (and galley schema V68) is a follow-up.
A rebase onto develop with bad conflict resolutions silently reverted newer upstream work: cannon.configuratorImage in the wire-server chart values (broke the kube-integration CI helm render at cannon/statefulset.yaml:146), the background-worker user-migration wiring (migrateUsers), meetings time-setting values/docs, and a separator line in postgres-schema.sql. Restore all of these from origin/develop; the MLS advisory-lock cutover needs none of the reverted content.
randomUser users are not connected, so galley rejects the commit bundle with 403 not-connected. Use createAndConnectUsers, matching the old testCommitLock and the other integration-package MLS tests.
blackheaven
force-pushed
the
gdifolco/WPB-22954-migration-postgres-mls-commit-locks
branch
from
November 13, 2026 11:46
7532eba to
2bfe2be
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-22954
Checklist
changelog.d