Skip to content

WPB-29617: determine scim invitation validity in postgres before pagination - #5664

Open
blackheaven wants to merge 3 commits into
gdifolco/WPB-29581-migration-postgres-invitationsfrom
gdifolco/WPB-29617-scim-expiration-postgres
Open

blackheaven wants to merge 3 commits into
gdifolco/WPB-29581-migration-postgres-invitationsfrom
gdifolco/WPB-29617-scim-expiration-postgres

Conversation

@blackheaven

@blackheaven blackheaven commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-29617

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@blackheaven
blackheaven requested review from a team as code owners October 26, 2026 17:27
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 26, 2026
@blackheaven
blackheaven changed the base branch from develop to gdifolco/WPB-29581-migration-postgres-invitations October 26, 2026 17:34
@blackheaven
blackheaven added this pull request to stack #5665 October 26, 2026 17:35
@blackheaven
blackheaven force-pushed the gdifolco/WPB-29617-scim-expiration-postgres branch from 5da6a4f to 9ee0e9f Compare October 29, 2026 16:05
@blackheaven
blackheaven force-pushed the gdifolco/WPB-29617-scim-expiration-postgres branch from 7afbb91 to c93ef3b Compare November 4, 2026 11:57
@blackheaven
blackheaven force-pushed the gdifolco/WPB-29617-scim-expiration-postgres branch 2 times, most recently from d227fbb to f3ce31e Compare November 10, 2026 09:03
…bility spec coverage

The listing now decides visibility in SQL, which silently dropped the old
enqueueUserDeletion on the listing path: expired pending SCIM users became
invisible but immortal (only the lazy getAccountsByImpl GC reaped them).
- New UserStore.GetExpiredPendingScimUsers effect: Postgres statement with
  the same pending shape as the visibility predicate and the live-invitation
  EXISTS negated; Cassandra returns [].
- getScimUsersPaginatedImpl enqueues their deletion after reading the page,
  so zombies are reaped eagerly on listing.
- In-memory user-store mock emulates the SQL visibility (pending shape +
  live-invitation check) and implements the new effect; the three deleted
  expiry-filter properties are restored against that emulation.
@blackheaven
blackheaven force-pushed the gdifolco/WPB-29617-scim-expiration-postgres branch from f3ce31e to f86e099 Compare November 13, 2026 17:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants