Repository navigation
WPB-29949: heal ghost MLS member-client rows from the ratchet tree - #5708
Open
blackheaven wants to merge 5 commits into
Open
blackheaven wants to merge 5 commits into
blackheaven wants to merge 5 commits into
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-29949-mls-ghost-client
branch
3 times, most recently
from
November 13, 2026 11:10
38284f6 to
ef2b039
Compare
Ghost clients (mls_group_member_client rows lost to the external-commit re-join race fixed in WPB-29648) left affected MLS groups permanently stuck: the client could send but never received fan-out, and remove/re-add failed with 400 mls-invalid-leaf-node-index because the ghost's leaf was absent from galley's IndexMap.
blackheaven
force-pushed
the
gdifolco/WPB-29949-mls-ghost-client
branch
from
November 13, 2026 13:01
ef2b039 to
9995a2b
Compare
The first commit of a conversation includes the sender in the Add action, so galley checks that all of alice's MLS-capable clients are covered. An already-registered key package for the non-member client alice2 made that check fail with 409 mls-client-mismatch. Upload alice2's key package right before her external commit instead, and give bob1 two key packages so the final re-add can still claim one.
setClientGroupState bob1 def also wiped the mls-cli keystore holding bob1's registered signature key, so the re-add key package was generated with a fresh identity key and brig rejected it with 400 'Unrecognised signature key'. Reset only the group state.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-29949
Checklist
changelog.d