Enable SHA3 on the secure wolfHSM server for the STM32H5 TrustZone port - #911
Open
aidangarske wants to merge 1 commit into
Open
aidangarske wants to merge 1 commit into
aidangarske wants to merge 1 commit into
Conversation
aidangarske
requested review from
danielinux
and
a lite review from Copilot
September 25, 2026 20:51
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Ensure sha3.o is included when HASH=SHA3 and HASH_HAL is non-empty.
Review effort: Lite
Findings: None
What changed in this PR
Enables SHA3 support in the STM32H5 TrustZone secure wolfHSM server.
Changes:
- Enables
WOLFSSL_SHA3in secure-side settings. - Links
sha3.ofor secure wolfHSM builds.
| File | Summary |
|---|---|
options.mk |
Adds the SHA3 implementation object; the HASH_HAL path still requires handling. |
include/user_settings.h |
Enables SHA3 in the secure wolfHSM configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Nightly wolfBoot TrustZone (m33mu) integration failed wolfHSM#412).
whTest_ClientConfig PASSED and all four SHA3 async variants succeed.