Skip to content

feat(generated): Changes to pipes - #561

Open
workos-sdk-automation[bot] wants to merge 4 commits into
mainfrom
oagen/batch-a5c70910
Open

workos-sdk-automation[bot] wants to merge 4 commits into
mainfrom
oagen/batch-a5c70910

Conversation

@workos-sdk-automation

@workos-sdk-automation workos-sdk-automation Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

feat(pipes): Change Pipes API surface

  • SDK surface change: Required parameter "user_id" added to "Pipes.create_organization_connected_account".
  • SDK surface change: Required parameter "user_id" added to "Pipes.update_organization_connected_account".

Triggered by workos/openapi-spec@0b0182d

BEGIN_COMMIT_OVERRIDE
feat(pipes): Change Pipes API surface (#561)
END_COMMIT_OVERRIDE

@workos-sdk-automation
workos-sdk-automation Bot requested a review from a team as a code owner September 25, 2026 17:40
@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 25, 2026
@workos-sdk-automation
workos-sdk-automation Bot requested a review from a team as a code owner September 25, 2026 17:40
@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 25, 2026
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Regenerated data integration API models and endpoints.

The PR is not yet safe to merge because the Pipes update signatures still reject supported connection-selection keywords for typed callers.

Findings

  1. P1 Update signatures omit selection keywords ▶
  2. P2 Creation tests ignore request bodies ▶
Fix with agent prompt
### Issue 1
rbi/workos/pipes.rbi:undefined-94
When a Sorbet-typed caller passes `connected_account_id` or `connection_intent` to reauthorize a specific API-key connection, this signature rejects the call even though the Ruby method accepts and sends both values. The client-credentials update signature has the same mismatch, so typed callers cannot select a connection through either method.

### Issue 2
test/workos/test_pipes.rb:49-53
This test checks only the URL and that a result is returned. It would pass if the new API-key creation method omitted `user_id`, the secret, or the required `connection_intent` from its JSON body. The new client-credentials test has the same gap. Checking the outgoing bodies would catch mistakes in these new request contracts.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR regenerates the Pipes SDK surface for connected-account creation, updates, and credential models. Since the previous review, only the pending changelog’s title marker changed.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Caller[Ruby application] --> Pipes[Pipes SDK]
  Pipes --> Create[Create connected account]
  Pipes --> Update[Update or reauthorize connection]
  Create --> API[WorkOS Pipes API]
  Update --> API
Loading

Reviews (2) · Last reviewed commit: "chore(generated): drop breaking marker f..."

Comment thread rbi/workos/pipes.rbi
).returns(WorkOS::ConnectedAccount)
end
def update_data_integration_api_key(slug:, user_id:, secret:, organization_id:, connected_account_id:, connection_owner:, request_options:); end
def update_data_integration_api_key(slug:, user_id:, secret:, organization_id:, connection_owner:, request_options:); end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Update signatures omit selection keywords
When a Sorbet-typed caller passes connected_account_id or connection_intent to reauthorize a specific API-key connection, this signature rejects the call even though the Ruby method accepts and sends both values. The client-credentials update signature has the same mismatch, so typed callers cannot select a connection through either method.

Knowledge Base Used: Connect, Pipes, and Admin Portal

Prompt To Fix With AI
This is a comment left during a code review.
Path: rbi/workos/pipes.rbi
Line: 94

Comment:
**Update signatures omit selection keywords**
When a Sorbet-typed caller passes `connected_account_id` or `connection_intent` to reauthorize a specific API-key connection, this signature rejects the call even though the Ruby method accepts and sends both values. The client-credentials update signature has the same mismatch, so typed callers cannot select a connection through either method.

**Knowledge Base Used:** [Connect, Pipes, and Admin Portal](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-ruby/-/docs/connect-pipes-and-admin-portal.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Comment thread test/workos/test_pipes.rb
Comment on lines +49 to +53
def test_create_data_integration_api_key_returns_expected_result
stub_request(:post, %r{\Ahttps://api\.workos\.com/data-integrations/stub/api-key(\?|\z)})
.to_return(body: "{}", status: 200)
result = @client.pipes.create_data_integration_api_key(slug: "stub", user_id: "stub", secret: "stub", connection_intent: "add")
refute_nil result

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Creation tests ignore request bodies
This test checks only the URL and that a result is returned. It would pass if the new API-key creation method omitted user_id, the secret, or the required connection_intent from its JSON body. The new client-credentials test has the same gap. Checking the outgoing bodies would catch mistakes in these new request contracts.

Prompt To Fix With AI
This is a comment left during a code review.
Path: test/workos/test_pipes.rb
Line: 49-53

Comment:
**Creation tests ignore request bodies**
This test checks only the URL and that a result is returned. It would pass if the new API-key creation method omitted `user_id`, the secret, or the required `connection_intent` from its JSON body. The new client-credentials test has the same gap. Checking the outgoing bodies would catch mistakes in these new request contracts.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@gjtorikian gjtorikian changed the title feat(generated)!: Changes to pipes feat(generated): Changes to pipes Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autogenerated Autogenerated code or content

Development

Successfully merging this pull request may close these issues.

1 participant