Repository navigation
fix(skill): handle Binance candle boundaries and USD volume - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents following the Binance guide could repeat a candle during backfill because the guide promises exclusive time bounds while live responses include the boundary. Teach millisecond pagination with
after=min(timestampMs)-1, strict timestamp filtering, a composite candle key, cursor-progress termination, and replacement of mutable open candles on refresh.Confirm the official USD volume mapping, describe shared request queues/cache/coalescing and 429 handling, and distinguish the still-missing serving price-info body from the already-correct xhub source contract. Keep price-info disabled until its live schema exposes the required array; a repository merge is not publication.
Rechecked BSC USDT, 1h, limit 3: equal after repeats one candle, minus 1ms does not; before also includes the boundary. Official schema defines prices and candle volume in USD:
https://web3.binance.com/en/dev-docs/catalog/web3-wallet/api/rest-api/1.0.0/schema.json
Validation:
bun install --frozen-lockfilepassedbun run typecheckpassedbun run buildpassedbun run test: 1457 passed, 0 failednpm pack --dry-run --ignore-scriptspassedNo version, release, or live provider configuration changes.