Repository navigation
Join consecutive short wrapped lines and CRLF text - #103
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
join_lines("a\nb\nc")leaves the second hard wrap intact because the regex consumes both neighboring characters. CRLF hard wraps also remain unchanged. Use zero-width boundary checks around LF/CRLF to replace every eligible line break while preserving paragraph boundaries, indentation and surrounding whitespace.Before: 2 regressions fail, paragraph/indentation control passes. After: all 3 focused tests pass on Python 3.10/3.12. Full Python 3.12 suite: 66 pass, 6 fail; untouched upstream has the same 6 Windows/platform failures and 63 passes. Pyflakes and diff checks pass. The existing failures involve bash/shell availability, HOME and termios; this does not claim a fully green Windows suite.
AI assistance: OpenAI Codex found this by code inspection, implemented and tested it at the account owner’s request ("15 TA koro aro"). No personal production incident or independent human review is claimed.