Repository navigation
Bump the vendored engine to 1737d72e, engine master - #257
Merged
Merged
Conversation
Brings the login-redaction work the logs needed. Logins are masked in hts-log.txt, hts-err.txt, hts-ioinfo.txt and the argument messages, run and log files are created owner-only on POSIX, which covers doit.log and its full command line, and there is a new export, hts_hide_secrets(), for engine text a front end displays. Also the login bundles, which this app does not use yet, and a 32-bit date fix that cannot reach us because we ship no 32-bit ABI. The bump adds three engine sources, and Android.mk carries an explicit list, so htsbundle.c and htsbundle_selftest.c are added to it. Both are needed: htscore.c, htslib.c and htsbauth.c call into the bundle, and htsselftest.c registers selftests_bundle. Measured rather than assumed. Without htsbundle.c the x86_64 link fails on six undefined hts_bundle_* symbols, and with it all three libraries link and the built libhttrack.so carries the bundle's own strings. BrowserLoginEngineLimitsTest went red on the bump, which is the guard working. The engine split cookie_load, so the comment markers the test read between now bracket a region holding none of the buffers it checks. It anchors on cookie_load_records instead, the function that parses a Netscape record. Every cap it asserts is unchanged, and shrinking one in the pinned source still turns it red. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <xroche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine now masks logins in
hts-log.txt,hts-err.txt,hts-ioinfo.txtand the argument messages, and creates its run and log files owner-only on POSIX. That second one coversdoit.log, which holds the whole command line. There is also a new export,hts_hide_secrets(), for engine text a front end shows.The bump adds three engine sources, and
Android.mkcarries an explicit list, sohtsbundle.candhtsbundle_selftest.cjoin it. Without the first, the x86_64 link fails on six undefinedhts_bundle_*symbols.BrowserLoginEngineLimitsTestwent red, which is the guard working. The engine splitcookie_load, so the markers the test reads between now bracket a region with none of the buffers it checks. It anchors oncookie_load_recordsinstead, and every cap it asserts is unchanged.Login bundles land here too, and nothing uses them.
versionNamekeeps its3.50.5prefix, becauseHTTRACK_VERSIONIDdid not move.