Repository navigation
Bump the vendored engine to 6bb24d1a, engine master - #259
Merged
Merged
Conversation
Three engine commits. Two came out of reviewing #258: -%X accepts a value beginning with a dash (#2007), and the header verdict bounds its field copy by its own buffer (#2008). The third is WebHTTrack's cURL-paste login (#2005), which does not ship here. Checked at the new pin: no engine source was added or removed, so Android.mk's explicit list is unchanged; HTTRACK_VERSIONID is still 3.50.5, so the versionName prefix needs no realign; the hts_header_verdict enum is byte-identical, so the ABI test still holds. Both ABIs build warning-clean and all 648 unit tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-%Xnow takes a value beginning with a dash, so such a header name reaches the wire instead of killing the crawl. All three sources the fix touches are inAndroid.mk's list.The header verdict the Browser ID page calls now bounds its field copy by its own buffer.
WebHTTrack's cURL-paste login lands too. Only
htsserver.cis outsideAndroid.mk's list, so most of its C does link in. The part that reaches a crawl iscookie_host, which now keys the jar by a host's punycode form. It refuses a host carrying a non-ASCII capital, and that host loses its cookies rather than failing the crawl. The engine'shtml/goes into the in-app Help, so that bundle gains one WebHTTrack page.No engine source was added or removed, so
Android.mkis unchanged, andversionNamekeeps its3.50.5prefix becauseHTTRACK_VERSIONIDdid not move. Nothing went red.