Repository navigation
Conversation
Author
|
I've run into the same config validation issue with my flasher addons, it's annoying lol. |
Adds a network_address config option (tcp://host:port) that takes priority over the device serial-port picker when set, wired through to ziggurat-server's --device flag (zigpy/ziggurat#39, merged). Wi-Fi-connected radios are not recommended. The device field is still required by the add-on's config form even when network_address is set (the form won't validate otherwise), but its value is functionally ignored in that case. Retains upstream's pinned Ziggurat revision and minimum Home Assistant version. Bumps the add-on to 0.5.0 for the new TCP configuration option. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
tube0013
force-pushed
the
Allow-TCP-based-rcp-config
branch
from
November 5, 2026 15:07
fae675e to
190d5d7
Compare
Author
|
Hi @puddly I rebased this do you think it can get be merged? it will stay hidden under the drop down until someone clicks that just like OTBR addon config. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
network_addressconfig option (tcp://host:port) that takes priority over thedeviceserial-port picker when set, wired through to ziggurat-server's--deviceflag (zigpy/ziggurat#39, merged). Wi-Fi-connected radios are not recommended.The device field is still required by the add-on's config form even when
network_addressis set (the form won't validate otherwise), but its value is functionally ignored in that case.Rebased onto current upstream
dev. Retains the upstream Ziggurat pin (1e319a4c41c71c3070524ca0599d101d3062acdb) and minimum Home Assistant version (2026.11.0b0), and bumps the add-on to0.5.0for the new configuration option. The pinned Ziggurat revision includes TCP RCP transport support.Validation: ShellCheck, Bash syntax validation, YAML parsing, and 12 mocked startup checks covering serial fallback and TCP precedence in Docker and Supervisor modes, with and without elevated scheduling priority. A local container build was not run because Docker is not installed.