Repository navigation
Drop legacy ziggurat-esp and ziggurat-phy-esp crates - #85
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the removal of the legacy ESP experiments.
No open issues 🎉
What changed in this PR
Removes the legacy bare-metal ESP experiments, aligning Ziggurat with the continued use of OpenThread RCP as its hardware abstraction layer.
Changes:
- Deletes the
ziggurat-espfirmware andziggurat-phy-espradio backend, including their build configuration and lockfiles. - Removes the deleted crates from workspace exclusions.
- Updates comments in the remaining OpenThread-related crates without changing their behavior.
| File | Description |
|---|---|
crates/ziggurat-phy-otlink/src/lib.rs |
Removes a legacy backend comparison from documentation. |
crates/ziggurat-phy-esp/src/lib.rs |
Deletes the native ESP radio backend. |
crates/ziggurat-phy-esp/Cargo.toml |
Deletes the radio backend manifest. |
crates/ziggurat-phy-esp/Cargo.lock |
Deletes the radio backend lockfile. |
crates/ziggurat-ncp-api/Cargo.toml |
Updates the workspace comment to omit the removed firmware. |
crates/ziggurat-esp/src/main.rs |
Deletes the ESP hardware bring-up entry point. |
crates/ziggurat-esp/src/hw_crypto.rs |
Deletes the legacy ESP hardware crypto backend. |
crates/ziggurat-esp/rust-toolchain.toml |
Deletes the firmware-specific toolchain configuration. |
crates/ziggurat-esp/Cargo.toml |
Deletes the firmware manifest and dependency patches. |
crates/ziggurat-esp/Cargo.lock |
Deletes the firmware lockfile. |
crates/ziggurat-esp/.cargo/config.toml |
Deletes the ESP build and flashing configuration. |
Cargo.toml |
Removes obsolete exclusions and updates workspace comments. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were earlier experiments that ran Ziggurat on bare metal, without using OpenThread RCP as a HAL. We're going to go with OpenThread RCP as a HAL for the foreseeable future and no longer need these crates.