Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the revised broadcast completion semantics.
No open issues 🎉
What changed in this PR
This PR makes missing broadcast passive acknowledgments an early-stopping concern rather than a send failure, aligning broadcast and groupcast completion semantics across the Zigbee stack, driver, and control protocol.
Changes:
- Report success when a broadcast schedule ends after at least one copy was transmitted, even without a passive-ACK quorum.
- Remove the quorum-not-reached error and its protocol mapping.
- Update documentation to describe completion in terms of retransmissions ending.
| File | Description |
|---|---|
crates/ziggurat-zigbee/src/sends/mod.rs |
Remove the quorum failure variant. |
crates/ziggurat-zigbee/src/sends/broadcasts.rs |
Succeed when retransmissions end after a successful handoff. |
crates/ziggurat-protocol/src/wire.rs |
Remove the quorum status and update confirmation documentation. |
crates/ziggurat-protocol/src/send_tracker.rs |
Clarify broadcast confirmation semantics in comments. |
crates/ziggurat-protocol/src/bridge.rs |
Remove the quorum error mapping and update documentation. |
crates/ziggurat-driver/src/zigbee_stack/send_handle.rs |
Document revised broadcast delivery semantics. |
crates/ziggurat-driver/src/zigbee_stack/nwk.rs |
Update the broadcast delivery comment. |
crates/ziggurat-driver/src/zigbee_stack/aps.rs |
Clarify broadcast and groupcast completion documentation. |
crates/ziggurat-driver/src/zigbee_stack.rs |
Remove the driver quorum error and conversion. |
Review effort: Balanced
Member
Author
|
I've modified the passive ACK algorithm to be a good mix of the two: we stop early if enough routers relay the broadcast but we only consider neighbors with a cost of 3 or better. This should exclude low-quality neighbors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec doesn't treat this as an error condition, just as an early stopping condition. I looked into how other stacks do this:
I'm a little conflicted about this change because while it does signal a useful error state (broadcasts aren't being received properly), what is an application supposed to do about it? If a router is offline, it won't be aged out for nearly a minute and the error state will persist until then. In the future, we should look into a granular, reactive counters API or something similar to stream error statuses (tied to individual requests) back to the application.