Repository navigation
tests: make the coordinator mocks pass zigpy's type check - #182
Merged
Merged
Conversation
zigpy 2.4 (b85807eb, "Split up BaseDevice into GreenPowerDevice and ZigbeeDevice") raises TypeError in ControllerApplication._device unless the coordinator is a ZigbeeDevice. test_rx, test_rx_nwk_0000 and test_rx_device_annce return plain MagicMocks from get_device, so they fail with "Coordinator <MagicMock ...> is not a Zigbee device". Signed-off-by: Thomas Roos <thomas@roosesweb.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 733 733
=========================================
Hits 733 733 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zigpy 2.4 (b85807eb, "Split up BaseDevice into GreenPowerDevice and
ZigbeeDevice") raises TypeError in ControllerApplication._device unless
the coordinator is a ZigbeeDevice. test_rx, test_rx_nwk_0000 and
test_rx_device_annce return plain MagicMocks from get_device, so they
fail with "Coordinator <MagicMock ...> is not a Zigbee device".
Found while running the zigpy-xbee tests against zigpy 2.4 for the Home Assistant 2026.11 packages of meta-homeassistant (Yocto): meta-homeassistant/meta-homeassistant#207
🤖 Generated with Claude Code
https://claude.ai/code/session_01FimvFQ6GCZWLoFogVCUeAK