Repository navigation
Get main green: full-fetch CI + UTF-8 tail/ignored-binary regression tests - #5
Merged
Merged
Conversation
Bytes 0x61 0xC3 stay the text "a", ignored paths are skipped before any decode, and the test job fetches tags so a released 0.3.0 matches v0.3.0 instead of failing as unreleased. Co-authored-by: ntc-ai <ntc-ai@users.noreply.github.com>
A short tail is text only when it ends the sample and every byte present is still a valid UTF-8 prefix. E0, ED, F0, and F4 second-byte ranges are enforced, so 61e080, 61eda0, 61f080, and 61f490 stay binary and include keeps the original bytes. Co-authored-by: ntc-ai <ntc-ai@users.noreply.github.com>
Deploying patchling with
|
| Latest commit: |
f26c770
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://423d3f96.patchling.pages.dev |
| Branch Preview URL: | https://cursor-main-green-utf8-915b.patchling.pages.dev |
mikkel
marked this pull request as ready for review
October 13, 2026 16:50
mikkel
added a commit
that referenced
this pull request
Oct 14, 2026
…ks (#6) * Exhaustive UTF-8 tail test and documented Cloudflare Pages deploy check Every 1-, 2- and 3-byte tail after 'a' (leads 80-FF, all continuations plus non-continuation probes) is classified as text exactly when a fatal streaming TextDecoder says a valid completion exists, and src/ and landing/lib/ agree on all of them. No mismatches were found. docs/deploy.md lists the expected Pages settings (production branch main, auto production deploys on, output dir landing, no build command). test/deploy_config.test.js asserts what the repo can prove, and scripts/check-pages-settings.sh checks the dashboard read-only. * Pages check: verify every documented setting, offline fixtures scripts/check-pages-settings.mjs replaces the shell script. It checks the repository, production branch, automatic production deployments, preview setting (all), build command, output and root directories, and the exact domain set, and exits 1 on any drift. It reads a saved API response with --from-file <path|->. test/check_pages_settings.test.js runs in npm test with a passing fixture, a negative case per check, and a check that the docs/deploy.md table equals EXPECTED. * Pages check: validate the API envelope offline too; check PR comments --from-file and stdin now go through the same envelope check as live mode: anything but success:true with an object result (success:false, a missing success or result, result:null, invalid JSON) exits 2 even when the project data matches. pr_comments_enabled is checked and documented. --------- Co-authored-by: ntc-ai <ntc-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the release-check CI failure (depth-1 checkout had no tags) and adds regression tests for Ember's findings: a truncated UTF-8 tail (b"a\xc3") keeps "a", and ignored binaries are excluded before decode. npm test: 177 pass, 4 live skipped, 0 fail.