Repository navigation
chore(types): Phase 4 of #415, type cli and remove overrides - #470
Merged
rosspeili merged 2 commits intoNov 9, 2026
Merged
Conversation
13 tasks
rosspeili
approved these changes
Nov 9, 2026
rosspeili
left a comment
Contributor
There was a problem hiding this comment.
LGTM! @UroojFatima-052, thanks a lot. Merging as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #415
Phase 4: removes
skillware.clifrom the mypy overrides and fixes the 3 errors that surfaced. Typing only, no behavior change.Changes
cli.py(_resolve_pytest_targets): the secondsearched: List[Path] = []drops its annotation, sincesearchedis already declared with that type in the earlierskill_idbranch of the same function (no-redef).cli.py(config submenu):child_nav: Optional[Union[int, str]] = None.cmd_addressbook_interactivereturnsint | str, while the other submenus returnOptional[str], so mypy rejected the assignment. This one wasn't in the issue list; it showed up once the override was removed.child_navis only compared against_NAV_EXIT, which works for all three types.cli.py(_lerp_rgb): returns an explicit 3-element tuple instead oftuple(... for i in range(3)), so the return type isTuple[int, int, int]rather thanTuple[int, ...]. Same values.pyproject.toml:cliwas the last module in[[tool.mypy.overrides]], and mypy rejects an override with an empty module list, so the whole block is removed here. Phase 5 then only needs to enablecheck_untyped_defsanddisallow_incomplete_defs.CHANGELOG.md: Unreleased entry.Verification
mypy skillware: Success, no issues in 25 files (no overrides)black --check/flake8oncli.py: cleanpytest tests/test_cli.py: 138 passed