fix(chat): defer independent pool judges in one-model runs - #1610
Closed
santoshkumarradha wants to merge 3 commits into
Closed
santoshkumarradha wants to merge 3 commits into
santoshkumarradha wants to merge 3 commits into
Conversation
This was referenced Sep 27, 2026
This was referenced Sep 27, 2026
santoshkumarradha
marked this pull request as ready for review
September 27, 2026 17:05
This was referenced Sep 27, 2026
Member
Author
|
Superseded by #1627. The exact reviewed source head is incorporated into Santosh/dev; its issue details, validation and recording links are preserved in the aggregate PR. Source history is retained. The aggregate remains draft pending combined acceptance; this closure does not mean dev has merged. |
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User workflow
Goal: With Model Pool reading enabled, build and use a pantry shopping CLI with a helper and README collaboration, then refine it for purchase quantities and fractional stock.
Observed outcome: The helper produced the initial CLI while the main conversation prepared documentation. A natural request for buy quantities and fractional values was completed in the main conversation after the helper returned its original scope. The final artifact passed 16 tests and actual text, JSON and oats/fraction output checks. All 105 receipts, including auxiliary and helper calls, used the requested DeepSeek model with no pool-judge calls/files.
Watch the workflow (MP4) · Animated GIF · Original terminal recording (.cast)
Evidence: tested revision
ffe8a20646a551afeed39c915951e8f70ed670e6. Execution/binary identity, model receipts, checksums and playback details. All 105 recorded calls used OpenRouterdeepseek/deepseek-v4.1-flash, including auxiliary calls. Independent generated-project checks. Source deliverable is retained in the evidence directory.Playback and limits: Playback is accelerated 3× with idle periods shortened. Model Pool was enabled in read mode and --one-model was supplied. Single-model sessions defer pool judging; ordinary pool resumption is verified by regression tests, not by a live run using alternate models. A note to an active helper does not replace its original acceptance contract; the recorded main conversation completed the revised requirements after the helper returned. This records that behavior rather than claiming helper scope changed automatically.
Revision note: recorded runtime
ffe8a20646a551afeed39c915951e8f70ed670e6; later headf1a677383changes onlydo_engine_test.gofor a fixture resource-setting regression tracked in #1615. The recording is not a new-head binary claim. Final localmake pr-readyand CI both passed after that test-only correction.chat --one-modelcould call a different model after a helper finished: Model Pool judging chose its own independent model. This launch now defers the optional task-landing judge and startup sweep. Ordinary launches keep independent judging; single-model launches neither self-judge nor consume pending judgments.Fixes #1608.
Validation: focused launch-policy and pending-sweep regressions passed. Final
make pr-readypassed atf1a677383(affectedcmd/codeafsuite 193.816s), and CI run 36334579868 is green. The original local run failed in preexisting test setup; its log is retained. The #1525 fixture correction published separately in #1615 is included here. The recorded runtime isffe8a20646; onlycmd/codeaf/do_engine_test.godiffers at the final head, so runtime code is identical. All 105 live receipts used the requested model with Model Pool enabled.