Skip to content

test: preserve machine gate settings when pinning run models - #1615

Closed
santoshkumarradha wants to merge 2 commits into
devfrom
codex/fix-1525-model-pin-fixtures
Closed

santoshkumarradha wants to merge 2 commits into
devfrom
codex/fix-1525-model-pin-fixtures

Conversation

@santoshkumarradha

@santoshkumarradha santoshkumarradha commented Sep 27, 2026 •

Copy link
Copy Markdown
Member

Three run-model tests replaced the complete profile after the shared fixture disabled machine load and memory gates. On a busy host this silently restored the default load limit, so the scripted jobs never started and timed out.

Apply model pins through the settings API, preserving the fixture's resource settings. This only changes test setup. Partially addresses #1525.

Spark evidence: unchanged base 837b2b0 reproduces the load refusal in 61.486 seconds; with the fix all three affected tests pass in 5.736 seconds while sharing the same loaded host. Final make pr-ready passed on Spark at 53877754b, including the complete affected cmd/codeaf suite in 233.832 seconds. CI run 36334534140 is green. No product runtime changed, so this fixture correction requires no separate model-driven workflow. Separate cleanup-race failures are investigated in #1616 and #1612; they are not masked by this change.

@santoshkumarradha
santoshkumarradha marked this pull request as ready for review September 27, 2026 16:59
@santoshkumarradha santoshkumarradha added the hygiene Tests, laws, dead code, duplication — no person-facing change label Sep 27, 2026
@santoshkumarradha santoshkumarradha added this to the Tests & tooling milestone Sep 27, 2026
@santoshkumarradha santoshkumarradha added area:tests The suite itself — flakes, harnesses, laws, CI reds area:session The engine — turns, tasks, the toolbelt, checkpoints labels Sep 27, 2026
@santoshkumarradha

Copy link
Copy Markdown
Member Author

Superseded by the consolidated draft #1627. Exact reviewed head 53877754b0835743d5ff4b4572766222bffb6967 is included in published Santosh/dev integration ef1ba797ab6adbf4ff519d5808316d07d982c002; ancestry was verified after push. Source findings, validation, recordings and limitations are preserved in #1627. This closes the separate review destination; dev/main were not merged and final aggregate acceptance is still pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:session The engine — turns, tasks, the toolbelt, checkpoints area:tests The suite itself — flakes, harnesses, laws, CI reds hygiene Tests, laws, dead code, duplication — no person-facing change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant