[sunib]

Stacked on #444.

Answers the gitops-api team's open asks that are small enough for one PR (docs/future/gitops-api-open-asks.md).

claimed_resource_reconciled_total (ask #31)

This counter is labelled {applier_kind, claim_namespace, claim_name}. It counts every apply an applier claim did not start: a held Kustomization resumed, or a held Application's automated sync switched on. The ClaimedResourceReconciled Event already said this, but the API server folds identical Events together and expires them.

Documented in interpreting-metrics.md, with a suggested alert, and in both applier guides.

Troubleshooting row (ask #32)

The Flux guide gets a troubleshooting row for a recurring ClaimedResourceReconciled. The cause is a controller that writes the Kustomization's whole spec without spec.suspend, which SuspendOwnedElsewhere cannot report.

Deleter attribution (ask #23)

New fact-index tests pin that a terminating object's removal names its deleter. They cover a finalizer cleared by an UPDATE as well as a PATCH, with the controller's fact filed before or after the deletion's. #431's fix holds.

Not changed

• Ask chore(deps): bump the go-dependencies group across 1 directory with 8 updates #28 (two instances in one cluster): deferred. Partitioning by namespace would remove only two of the four costs the team lists. The CRDs and the ClusterRole stay shared, so the instances would keep one upgrade cadence and one RBAC posture. It is not the HA mechanism either, and it would add a second tenancy model beside one instance serving many namespaces through grants. The team is not blocked: one shared instance works. The asks doc records the reasoning. The restart cost behind the ask belongs to the durable pending writes in the TODO.
• Ask ci(deps): Bump actions/download-artifact from 3 to 5 #11: already shipped in 0.41.0 (fix(analyzer)!: a refusal that can be fixed must not call itself unsupported, and one encoder for the mirror #290). Create and update write through one encoder (internal/yamlstyle), and a test fails on a second one. The asks doc and the TODO drop it.
• Ask feat: Time for devcontainers! #34's side notes: both are answered in the asks doc. OperationUnresolved appearing on three objects is readiness projection, not three separate records. sent is never counted for an apply that wasn't needed.
• Ask feat: Time for devcontainers! #34 itself: the e2e is left out until the e2e budget allows, as the team suggested.
• Ask deps(deps): Bump k8s.io/client-go from 0.33.0 to 0.33.3 #10: not built; still open in the asks doc and the TODO.

Testing

• task lint passes.
• task test passes, with coverage at 80.1% against a baseline of 80.2% (tolerance 0.5%).
• New tests:
  • counter assertions in the Flux and Argo CD resume tests
  • TestFactIndex_AFinalizerClearedByAControllerNamesTheDeleter
• e2e: see the CI legs.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: b401161a-aed0-4d3b-abd2-251f37103035

Commits

Reviewing files that changed from the base of the PR and between 7845f59 and f2146be.

Files selected for processing: 12

• docs/TODO.md
• docs/bi-directional-argocd.md
• docs/bi-directional-flux.md
• docs/future/gitops-api-open-asks.md
• docs/interpreting-metrics.md
• internal/controller/argocdclaim_hold.go
• internal/controller/argocdclaim_hold_test.go
• internal/controller/fluxclaim_hold.go
• internal/controller/fluxclaim_hold_test.go
• internal/queue/fact_index_removal_cause_test.go
• internal/telemetry/apply_requests.go
• internal/telemetry/exporter.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/controller/fluxclaim_hold.go	88.8%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!