Skip to content

Update keyword foundation and align generated editor schemas - #107

Merged
patrickwieth merged 6 commits into
masterfrom
fix/keyword-schema-editor-fields
Oct 24, 2026
Merged

patrickwieth merged 6 commits into
masterfrom
fix/keyword-schema-editor-fields

Conversation

@patrickwieth

Copy link
Copy Markdown
Member

Summary

Bring the keyword-foundation branch into master, including the clarified Loot description, the new keyword grammar/class definitions and parameterless Sacrifice.

The final follow-up fixes generated editor interaction texts so that they only reference fields actually present in the keyword card types. Retired Keywords/RulesTexts and HQ-only legacy placeholders no longer create invalid editor controls. Both generated schemas are synchronized, and a regression test checks all interaction placeholders against their declared children.

Validation

  • go test -p 2 ./... repeated after the development VM restart.
  • The frontend schema exactly matches the generated keywordedSchema.json.
  • Real browser AbilityModal selection and the four card-type serializers are tested in the companion frontend change.

Cardchain pins commit c8c0da79c0db8b4b27c083754325f1e40ca3c07b as the public Go module version v0.5.3-0.20261023051040-c8c0da79c0db; no sibling checkout is needed.

@patrickwieth

Copy link
Copy Markdown
Member Author

Companion PRs: Cardchain #267 pins this exact Cardobject commit and includes the reviewed genesis/deployment contract. Frontend #353 consumes the generated keyword schema and fixes the necessary editor compatibility paths.

@patrickwieth

Copy link
Copy Markdown
Member Author

Merged current master into this PR and resolved the Count Dust label conflict as Count §CardType Dust -> X. so both the Dust context and the assignment to X remain explicit. Regenerated the schema from the merged Go source rather than choosing one generated JSON side. go test -p 2 ./... passes. GitHub now reports this PR as mergeable/clean. Resolution commit: 48543be.

@patrickwieth
patrickwieth merged commit dad764e into master Oct 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant