Skip to content

Integrate keyword schema compatibility and fix gallery loading - #353

Merged
patrickwieth merged 2 commits into
masterfrom
fix/cardobject-creator-compatibility
Oct 24, 2026
Merged

patrickwieth merged 2 commits into
masterfrom
fix/cardobject-creator-compatibility

Conversation

@patrickwieth

@patrickwieth patrickwieth commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Required Cardobject schema / merge coordination

This frontend targets the new Cardobject grammar from merged Cardobject PR #107.

The generated cardRules.json now comes from merged master commit dad764e41bae3da9e929a34f32193c7f6f84e9b4. The frontend does not install the Go module separately. Cardchain #267 is already merged; Cardchain follow-up #268 pins the same merged Cardobject commit.

The post-merge synchronization changes only six schema labels/descriptions, not card JSON structure. Compatibility tests (with label regression assertions), TypeScript/production build and the real AbilityModal browser check were rerun successfully. CardchainCS and gameclient are untouched.

Scope

Only the necessary Cardobject/Cardchain compatibility changes and the reported existing gallery loading bug. No Run Deck/All-Star UI, frame-economy changes or gameclient modifications.

Changes

  • Import the exact keyword schema from merged Cardobject commit dad764e41bae.
  • Resolve recursive references as shared objects so Reprogram/Requiem do not leave effect pickers unresolved.
  • Preserve typed CHOSEN values in data and shorten only rendered rule text.
  • Serialize only fields appropriate to each card type, omitting legacy RulesTexts and unrelated default fields.
  • Add an opt-in development REST adapter (VITE_APP_DEVELOPMENT_CHAIN_API=true); default client behavior remains unchanged.
  • Fix Reckless Card Loading to listen to the actual scrolling panel and recheck after asynchronous batches.

Validation

  • node scripts/test-cardobject-compat.cjs.
  • npm run build (includes TypeScript check).
  • REST adapter request/response tests.
  • Browser checks of the real AbilityModal, migrated card text, gallery/editor loading, and scrolling to the complete reviewed card set.

Local review pages, local endpoint overrides, keys and snapshots are excluded. Signed Card Creator/wallet transaction compatibility is not claimed; this adapter only handles REST queries. Existing dependency/build warnings are not resolved by this scoped change.

@patrickwieth

Copy link
Copy Markdown
Member Author

Companion PRs: Cardobject #107 supplies the exact generated keyword schema; Cardchain #267 supplies the compatible chain core and reviewed 552-card genesis. This frontend PR does not add Run Deck/All-Star UI.

@patrickwieth
patrickwieth merged commit 9df0a8f into master Oct 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant