Repository navigation
Integrate keyword schema compatibility and fix gallery loading - #353
Merged
Merged
Conversation
Member
Author
|
Companion PRs: Cardobject #107 supplies the exact generated keyword schema; Cardchain #267 supplies the compatible chain core and reviewed 552-card genesis. This frontend PR does not add Run Deck/All-Star UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required Cardobject schema / merge coordination
This frontend targets the new Cardobject grammar from merged Cardobject PR #107.
The generated
cardRules.jsonnow comes from merged master commitdad764e41bae3da9e929a34f32193c7f6f84e9b4. The frontend does not install the Go module separately. Cardchain #267 is already merged; Cardchain follow-up #268 pins the same merged Cardobject commit.The post-merge synchronization changes only six schema labels/descriptions, not card JSON structure. Compatibility tests (with label regression assertions), TypeScript/production build and the real AbilityModal browser check were rerun successfully. CardchainCS and gameclient are untouched.
Scope
Only the necessary Cardobject/Cardchain compatibility changes and the reported existing gallery loading bug. No Run Deck/All-Star UI, frame-economy changes or gameclient modifications.
Changes
dad764e41bae.VITE_APP_DEVELOPMENT_CHAIN_API=true); default client behavior remains unchanged.Validation
node scripts/test-cardobject-compat.cjs.npm run build(includes TypeScript check).Local review pages, local endpoint overrides, keys and snapshots are excluded. Signed Card Creator/wallet transaction compatibility is not claimed; this adapter only handles REST queries. Existing dependency/build warnings are not resolved by this scoped change.