Repository navigation
Conversation
b186307 to
810501f
Compare
810501f to
9dcbc33
Compare
9dcbc33 to
faf197a
Compare
faf197a to
8ae0d63
Compare
[Medium impact] The PR appears safe to merge, with a non-blocking issue affecting textures on local Collada robot meshes.
|
| files.update(_check_dependencies(root, path)) | ||
| if path.suffix.lower() not in {".urdf", ".xml"}: | ||
| continue |
There was a problem hiding this comment.
Local robots that use textured Collada meshes lose their images during bundling. _check_dependencies returns only the .dae file, and _resource_files skips its contents because it only parses .urdf and .xml. The new selective copy therefore leaves out images named by Collada init_from, which the old directory copy preserved.
Follow those image references when building the copy list so deployed robots keep their textures.
Prompt To Fix With AI
This is a comment left during a code review.
Path: embodichain/lab/task_program/integrations/asset_materialization.py
Line: 136-138
Comment:
**Collada textures disappear**
Local robots that use textured Collada meshes lose their images during bundling. `_check_dependencies` returns only the `.dae` file, and `_resource_files` skips its contents because it only parses `.urdf` and `.xml`. The new selective copy therefore leaves out images named by Collada `init_from`, which the old directory copy preserved.
Follow those image references when building the copy list so deployed robots keep their textures.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Description
Build standalone physical and semantic deployment configurations from verified asset selections. Preserve logical roles, derive fresh registration identities, adapt supported relative placement frames and reject stale geometry calibrations. Explicit local resources resolve from their declaring component; dataset identifiers retain registry semantics.
Generated asset references retain their output-directory owner through bundling. Local resources include only their dependency closure, use content-addressed paths and participate in deployment identity. Validation requires complete selected-asset and local-resource inventories even when restoring an artifact without the optional manifest digest. Background bodies inherit the production loader's static default.
Refs #810. This is layer 4/5 of the currently authorized asset-generalization implementation. PR6 online generation is deferred; no generation service is invoked by this stack.
Stack
mainValidation
black .), the public API documentation coverage gate, context validation and changed-file syntax/header/export checks passed.Tests use repository-pinned DexSim 0.5.1rc1 and matching Warp 1.17.0. The installed-package subprocess check passed in a temporary isolated virtual environment because that test replaces PYTHONPATH and otherwise selects the workstation's broken editable DexSim build. No shared environment installation was modified.
Context guidance now describes resource ownership, content identity and complete inventories; physical component ownership and existing API reference entries remain applicable. These fixes were validated with CPU tests and static preflight; native simulation was not rerun.
Type of change
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py).