Repository navigation
Conversation
yuecideng
added this pull request to stack #816
October 18, 2026 12:08
5 tasks done
This was referenced Oct 18, 2026
yuecideng
force-pushed
the
codex/asset-generalization-matching
branch
from
October 18, 2026 12:15
5e90fe6 to
2d5e55d
Compare
yuecideng
force-pushed
the
codex/asset-generalization-matching
branch
from
October 18, 2026 15:49
2d5e55d to
084c121
Compare
yuecideng
marked this pull request as ready for review
October 18, 2026 15:50
5 tasks done
[Medium impact] The PR appears safe to merge; no blocking issue remains. SummaryAdds deterministic asset matching for task roles.
|
yuecideng
force-pushed
the
codex/asset-generalization-matching
branch
from
October 18, 2026 16:04
084c121 to
81ffe5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Select normalized prepared assets that satisfy category, attribute, capability and extent constraints, then jointly check annotated support/containment relations. Stable seed-based ordering and bounded lazy search produce immutable asset-set identities or structured rejection reports.
Refs #810. This is layer 3/5 of the currently authorized asset-generalization implementation. PR6 online generation is deferred; no generation service is invoked by this stack.
Stack
codex/asset-generalization-sourcesValidation
23 matcher tests passed, covering aliases, unknown attributes, missing capabilities/regions, incompatible combinations, stable identities and candidate/search budgets. CPU work is bounded by explicit candidate and search-node limits; no Cartesian product is allocated and no throughput claim is made.
Tests use the repository-pinned DexSim 0.5.1rc1 and its matching Warp 1.17.0 via a process-local dependency path. The workstation's default editable DexSim build has an unrelated import failure; no shared environment installation was modified.
Black 26.3.1 formatting passed. Final-stack API coverage is 2640/2640 exports; the Sphinx dummy build completed with warnings/errors originating in unchanged documentation/docstrings and no diagnostics for the new asset modules. Context review adds the asset-generalization topic and updates component/semantic ownership where behavior changed. Existing data download and scene acceptance guidance remains applicable.
Type of change
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py).CI collection fix
The asset-catalog tests now form an explicit Python package, avoiding the top-level
test_contractsmodule collision with existing scene-expansion tests under pytest's default import mode. The original two-file collection failure was reproduced before the fix. Combined asset, role, matcher and scene-contract validation passed 94 tests at the third layer; runtime APIs are unchanged. CI passed and PRs #811–#813 were squash-merged together into main. Higher layers remain drafts.Review boundary fixes
Confirmed and fixed rejection-report truncation: the 100-entry cap applies to candidate details, while per-role summaries and search-budget stop reasons are retained. Both regressions failed before the fix and pass afterward. Combined validation across the first three layers and scene contracts now passes 99 tests.