Repository navigation
Add provider-neutral asset and task role contracts - #811
Merged
Merged
Conversation
yuecideng
added this pull request to stack #816
October 18, 2026 12:08
This was referenced Oct 18, 2026
yuecideng
marked this pull request as ready for review
October 18, 2026 15:50
5 tasks done
[Medium impact] The PR appears safe to merge with PR #812's region-within-bounds check included. SummaryAdds immutable, provider-neutral asset records and task-owned role requirements.
This assessment depends on PR #812, which adds checks that usable regions stay inside object bounds. That fix is not present in this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Define immutable asset descriptions, candidates, prepared snapshots and the external Provider protocol. Task Program owns role requirements, explicit category aliases and geometric relations; contracts do not fetch assets or instantiate simulation.
Refs #810. This is layer 1/5 of the currently authorized asset-generalization implementation. PR6 online generation is deferred; no generation service is invoked by this stack.
Stack
mainValidation
Provider-neutral data and role-contract tests cover invalid numeric values, unknown fields, JSON ownership and semantic references. New routed context and API reference entries describe the ownership boundary.
Tests use the repository-pinned DexSim 0.5.1rc1 and its matching Warp 1.17.0 via a process-local dependency path. The workstation's default editable DexSim build has an unrelated import failure; no shared environment installation was modified.
Black 26.3.1 formatting passed. Final-stack API coverage is 2640/2640 exports; the Sphinx dummy build completed with warnings/errors originating in unchanged documentation/docstrings and no diagnostics for the new asset modules. Context review adds the asset-generalization topic and updates component/semantic ownership where behavior changed. Existing data download and scene acceptance guidance remains applicable.
Type of change
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py).CI collection fix
The asset-catalog tests now form an explicit Python package, avoiding the top-level
test_contractsmodule collision with existing scene-expansion tests under pytest's default import mode. The original two-file collection failure was reproduced before the fix. Combined asset, role, matcher and scene-contract validation passed 94 tests at the third layer; runtime APIs are unchanged. CI passed and PRs #811–#813 were squash-merged together into main. Higher layers remain drafts.